diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2001-10-05 17:28:13 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2001-10-05 17:28:13 +0000 |
| commit | 8a52b893b3d83c6dc796fae6a07a4ac30c871fc4 (patch) | |
| tree | 65b88475931f536afffe13f489c10167a8b12a12 /src/backend/executor/spi.c | |
| parent | 343318028fb4aca0c69663c7d429d602a32aaf02 (diff) | |
| download | postgresql-8a52b893b3d83c6dc796fae6a07a4ac30c871fc4.tar.gz postgresql-8a52b893b3d83c6dc796fae6a07a4ac30c871fc4.zip | |
Further cleanup of dynahash.c API, in pursuit of portability and
readability. Bizarre '(long *) TRUE' return convention is gone,
in favor of just raising an error internally in dynahash.c when
we detect hashtable corruption. HashTableWalk is gone, in favor
of using hash_seq_search directly, since it had no hope of working
with non-LONGALIGNable datatypes. Simplify some other code that was
made undesirably grotty by promixity to HashTableWalk.
Diffstat (limited to 'src/backend/executor/spi.c')
| -rw-r--r-- | src/backend/executor/spi.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c index 8c6420ae4cc..29e4729351d 100644 --- a/src/backend/executor/spi.c +++ b/src/backend/executor/spi.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/executor/spi.c,v 1.57 2001/08/02 18:08:43 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/executor/spi.c,v 1.58 2001/10/05 17:28:12 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -783,12 +783,10 @@ SPI_cursor_move(Portal portal, bool forward, int count) void SPI_cursor_close(Portal portal) { - Portal my_portal = portal; - - if (!PortalIsValid(my_portal)) + if (!PortalIsValid(portal)) elog(ERROR, "invalid portal in SPI cursor operation"); - PortalDrop(&my_portal); + PortalDrop(portal); } /* =================== private functions =================== */ |