aboutsummaryrefslogtreecommitdiff
path: root/src/backend/executor
diff options
context:
space:
mode:
authorAmit Kapila <akapila@postgresql.org>2023-03-21 09:18:51 +0530
committerAmit Kapila <akapila@postgresql.org>2023-03-21 09:18:51 +0530
commit65ead76961a4be9a10d1c7dbfdcb10765aad8af9 (patch)
tree5b6cc1997ffdfa47cc7a8415b16193cf4bd15e17 /src/backend/executor
parent1b9e42e82ae62f2a53e4a3da19b5fff994af5d72 (diff)
downloadpostgresql-65ead76961a4be9a10d1c7dbfdcb10765aad8af9.tar.gz
postgresql-65ead76961a4be9a10d1c7dbfdcb10765aad8af9.zip
Ignore dropped columns during apply of update/delete.
We fail to apply updates and deletes when the REPLICA IDENTITY FULL is used for the table having dropped columns. We didn't use to ignore dropped columns while doing tuple comparison among the tuples from the publisher and subscriber during apply of updates and deletes. Author: Onder Kalaci, Shi yu Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/CACawEhVQC9WoofunvXg12aXtbqKnEgWxoRx3+v8q32AWYsdpGg@mail.gmail.com
Diffstat (limited to 'src/backend/executor')
-rw-r--r--src/backend/executor/execReplication.c10
1 files changed, 8 insertions, 2 deletions
diff --git a/src/backend/executor/execReplication.c b/src/backend/executor/execReplication.c
index 8f116b78cc3..db7414eaf7e 100644
--- a/src/backend/executor/execReplication.c
+++ b/src/backend/executor/execReplication.c
@@ -243,6 +243,14 @@ tuples_equal(TupleTableSlot *slot1, TupleTableSlot *slot2,
Form_pg_attribute att;
TypeCacheEntry *typentry;
+ att = TupleDescAttr(slot1->tts_tupleDescriptor, attrnum);
+
+ /*
+ * Ignore dropped columns as the publisher doesn't send those
+ */
+ if (att->attisdropped)
+ continue;
+
/*
* If one value is NULL and other is not, then they are certainly not
* equal
@@ -256,8 +264,6 @@ tuples_equal(TupleTableSlot *slot1, TupleTableSlot *slot2,
if (slot1->tts_isnull[attrnum] || slot2->tts_isnull[attrnum])
continue;
- att = TupleDescAttr(slot1->tts_tupleDescriptor, attrnum);
-
typentry = eq[attrnum];
if (typentry == NULL)
{