aboutsummaryrefslogtreecommitdiff
path: root/src/backend/executor
diff options
context:
space:
mode:
authorAlvaro Herrera <alvherre@alvh.no-ip.org>2014-11-08 00:31:03 -0300
committerAlvaro Herrera <alvherre@alvh.no-ip.org>2014-11-08 00:31:03 -0300
commitb89ee54e20e722bb91f388667586a2e0986f197b (patch)
tree896df39d9e413e9cc9b59847a6fa60b84de4b73c /src/backend/executor
parent926f5cea472676b8378f02cd80c2c5f86226d981 (diff)
downloadpostgresql-b89ee54e20e722bb91f388667586a2e0986f197b.tar.gz
postgresql-b89ee54e20e722bb91f388667586a2e0986f197b.zip
Fix some coding issues in BRIN
Reported by David Rowley: variadic macros are a problem. Get rid of them using a trick suggested by Tom Lane: add extra parentheses where needed. In the future we might decide we don't need the calls at all and remove them, but it seems appropriate to keep them while this code is still new. Also from David Rowley: brininsert() was trying to use a variable before initializing it. Fix by moving the brin_form_tuple call (which initializes the variable) to within the locked section. Reported by Peter Eisentraut: can't use "new" as a struct member name, because C++ compilers will choke on it, as reported by cpluspluscheck.
Diffstat (limited to 'src/backend/executor')
0 files changed, 0 insertions, 0 deletions