diff options
| author | Amit Kapila <akapila@postgresql.org> | 2023-03-21 08:50:23 +0530 |
|---|---|---|
| committer | Amit Kapila <akapila@postgresql.org> | 2023-03-21 08:50:23 +0530 |
| commit | fc63e6ba8670e0eb1bc40ae9fe4acdd4203bc36e (patch) | |
| tree | a1a9a4a823b09de0ee2f968cd36af98200765350 /src/backend/executor | |
| parent | 44d44aa9712f315b125c9c5f2a1640ebb70e1d2f (diff) | |
| download | postgresql-fc63e6ba8670e0eb1bc40ae9fe4acdd4203bc36e.tar.gz postgresql-fc63e6ba8670e0eb1bc40ae9fe4acdd4203bc36e.zip | |
Ignore dropped columns during apply of update/delete.
We fail to apply updates and deletes when the REPLICA IDENTITY FULL is
used for the table having dropped columns. We didn't use to ignore dropped
columns while doing tuple comparison among the tuples from the publisher
and subscriber during apply of updates and deletes.
Author: Onder Kalaci, Shi yu
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/CACawEhVQC9WoofunvXg12aXtbqKnEgWxoRx3+v8q32AWYsdpGg@mail.gmail.com
Diffstat (limited to 'src/backend/executor')
| -rw-r--r-- | src/backend/executor/execReplication.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/backend/executor/execReplication.c b/src/backend/executor/execReplication.c index 62893221273..02b33002136 100644 --- a/src/backend/executor/execReplication.c +++ b/src/backend/executor/execReplication.c @@ -242,6 +242,14 @@ tuples_equal(TupleTableSlot *slot1, TupleTableSlot *slot2) Form_pg_attribute att; TypeCacheEntry *typentry; + att = TupleDescAttr(slot1->tts_tupleDescriptor, attrnum); + + /* + * Ignore dropped columns as the publisher doesn't send those + */ + if (att->attisdropped) + continue; + /* * If one value is NULL and other is not, then they are certainly not * equal @@ -255,8 +263,6 @@ tuples_equal(TupleTableSlot *slot1, TupleTableSlot *slot2) if (slot1->tts_isnull[attrnum] || slot2->tts_isnull[attrnum]) continue; - att = TupleDescAttr(slot1->tts_tupleDescriptor, attrnum); - typentry = lookup_type_cache(att->atttypid, TYPECACHE_EQ_OPR_FINFO); if (!OidIsValid(typentry->eq_opr_finfo.fn_oid)) ereport(ERROR, |