diff options
| author | Michael Paquier <michael@paquier.xyz> | 2024-01-12 12:04:51 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2024-01-12 12:04:51 +0900 |
| commit | e72a37528ddaadd796be73fe9b0a0c08b18476d2 (patch) | |
| tree | f1e827966b3b0e02ed56b6cfbe96e9f266d6e610 /src/backend/jit | |
| parent | 08c3ad27eb5348d0cbffa843a3edb11534f9904a (diff) | |
| download | postgresql-e72a37528ddaadd796be73fe9b0a0c08b18476d2.tar.gz postgresql-e72a37528ddaadd796be73fe9b0a0c08b18476d2.zip | |
Refactor code checking for file existence
jit.c and dfgr.c had a copy of the same code to check if a file exists
or not, with a twist: jit.c did not check for EACCES when failing the
stat() call for the path whose existence is tested. This refactored
routine will be used by an upcoming patch.
Reviewed-by: Ashutosh Bapat
Discussion: https://postgr.es/m/ZTiV8tn_MIb_H2rE@paquier.xyz
Diffstat (limited to 'src/backend/jit')
| -rw-r--r-- | src/backend/jit/jit.c | 20 |
1 files changed, 1 insertions, 19 deletions
diff --git a/src/backend/jit/jit.c b/src/backend/jit/jit.c index 3f9848e726b..d323c199eaa 100644 --- a/src/backend/jit/jit.c +++ b/src/backend/jit/jit.c @@ -45,7 +45,6 @@ static bool provider_failed_loading = false; static bool provider_init(void); -static bool file_exists(const char *name); /* @@ -89,7 +88,7 @@ provider_init(void) */ snprintf(path, MAXPGPATH, "%s/%s%s", pkglib_path, jit_provider, DLSUFFIX); elog(DEBUG1, "probing availability of JIT provider at %s", path); - if (!file_exists(path)) + if (!pg_file_exists(path)) { elog(DEBUG1, "provider not available, disabling JIT for current session"); @@ -188,20 +187,3 @@ InstrJitAgg(JitInstrumentation *dst, JitInstrumentation *add) INSTR_TIME_ADD(dst->optimization_counter, add->optimization_counter); INSTR_TIME_ADD(dst->emission_counter, add->emission_counter); } - -static bool -file_exists(const char *name) -{ - struct stat st; - - Assert(name != NULL); - - if (stat(name, &st) == 0) - return !S_ISDIR(st.st_mode); - else if (!(errno == ENOENT || errno == ENOTDIR)) - ereport(ERROR, - (errcode_for_file_access(), - errmsg("could not access file \"%s\": %m", name))); - - return false; -} |