diff options
| author | Noah Misch <noah@leadboat.com> | 2016-11-07 20:27:30 -0500 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2016-11-07 20:27:35 -0500 |
| commit | 91ba77c722928429ebdb042075f7c0bf9d50cf34 (patch) | |
| tree | ad6ea81ddfd80ff5606a48d0637cc8e4d7ffe6df /src/backend/lib/binaryheap.c | |
| parent | 5ee3a7453a428890ed4c0a1061c367e510b8253b (diff) | |
| download | postgresql-91ba77c722928429ebdb042075f7c0bf9d50cf34.tar.gz postgresql-91ba77c722928429ebdb042075f7c0bf9d50cf34.zip | |
Change qr/foo$/m to qr/foo\n/m, for Perl 5.8.8.
In each case, absence of a trailing newline would itself constitute a
PostgreSQL bug. Therefore, this slightly enhances the changed tests.
This works around a bug that last appeared in Perl 5.8.8, fixing
src/test/modules/test_pg_dump when run against that version. Commit
e7293e3271bf618eeb2d4779a15fc516a69fe463 worked around the bug, but the
subsequent addition of test_pg_dump introduced affected code. As that
commit had shown, slight increases in pattern complexity can suppress
the bug. This commit edits qr/foo$/m patterns too complex to encounter
the bug today, for style consistency and robustness against unrelated
pattern changes. Back-patch to 9.6, where test_pg_dump was introduced.
As of this writing, a fresh MSYS installation includes an affected Perl
5.8.8. The Perl 5.8.8 in Red Hat Enterprise Linux 5.11 carries a patch
that renders it unaffected, but the Perl 5.8.5 of Red Hat Enterprise
Linux 4.4 is affected.
Diffstat (limited to 'src/backend/lib/binaryheap.c')
0 files changed, 0 insertions, 0 deletions