diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-05-21 00:32:28 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-05-21 00:32:48 -0400 |
| commit | ced0cdc76cfc09eaa722e79fe9720729703da2ce (patch) | |
| tree | 3ce0f28ffd1ba0f076099a57a91b35e59f6680fe /src/backend/libpq/auth.c | |
| parent | 29a4db65fbb752b2c0b212f331eb375532a7b9d9 (diff) | |
| download | postgresql-ced0cdc76cfc09eaa722e79fe9720729703da2ce.tar.gz postgresql-ced0cdc76cfc09eaa722e79fe9720729703da2ce.zip | |
Fix unsafe usage of strerror(errno) within ereport().
This is the converse of the unsafe-usage-of-%m problem: the reason
ereport/elog provide that format code is mainly to dodge the hazard
of errno getting changed before control reaches functions within the
arguments of the macro. I only found one instance of this hazard,
but it's been there since 9.4 :-(.
Diffstat (limited to 'src/backend/libpq/auth.c')
| -rw-r--r-- | src/backend/libpq/auth.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c index 8fb518dbc24..c3339b0ce76 100644 --- a/src/backend/libpq/auth.c +++ b/src/backend/libpq/auth.c @@ -1620,10 +1620,12 @@ auth_peer(hbaPort *port) pw = getpwuid(uid); if (!pw) { + int save_errno = errno; + ereport(LOG, (errmsg("could not look up local user ID %ld: %s", (long) uid, - errno ? strerror(errno) : _("user does not exist")))); + save_errno ? strerror(save_errno) : _("user does not exist")))); return STATUS_ERROR; } |