diff options
| author | Amit Kapila <akapila@postgresql.org> | 2018-09-14 10:05:45 +0530 |
|---|---|---|
| committer | Amit Kapila <akapila@postgresql.org> | 2018-09-14 10:05:45 +0530 |
| commit | 1ceb103e7d1e794c0b171b0594fc6936003eb4ab (patch) | |
| tree | 654e600860a858eb03574dd238226c154cdeec41 /src/backend/optimizer/path | |
| parent | ede7d8192ca3d1f731d34fb82fdcfc3308b4355f (diff) | |
| download | postgresql-1ceb103e7d1e794c0b171b0594fc6936003eb4ab.tar.gz postgresql-1ceb103e7d1e794c0b171b0594fc6936003eb4ab.zip | |
Don't allow LIMIT/OFFSET clause within sub-selects to be pushed to workers.
Allowing sub-select containing LIMIT/OFFSET in workers can lead to
inconsistent results at the top-level as there is no guarantee that the
row order will be fully deterministic. The fix is to prohibit pushing
LIMIT/OFFSET within sub-selects to workers.
Reported-by: Andrew Fletcher
Bug: 15324
Author: Amit Kapila
Reviewed-by: Dilip Kumar
Backpatch-through: 9.6
Discussion: https://postgr.es/m/153417684333.10284.11356259990921828616@wrigleys.postgresql.org
Diffstat (limited to 'src/backend/optimizer/path')
| -rw-r--r-- | src/backend/optimizer/path/allpaths.c | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/src/backend/optimizer/path/allpaths.c b/src/backend/optimizer/path/allpaths.c index fff2f4c8bad..d9a2f9bf695 100644 --- a/src/backend/optimizer/path/allpaths.c +++ b/src/backend/optimizer/path/allpaths.c @@ -612,7 +612,20 @@ set_rel_consider_parallel(PlannerInfo *root, RelOptInfo *rel, * the SubqueryScanPath as not parallel-safe. (Note that * set_subquery_pathlist() might push some of these quals down * into the subquery itself, but that doesn't change anything.) + * + * We can't push sub-select containing LIMIT/OFFSET to workers as + * there is no guarantee that the row order will be fully + * deterministic, and applying LIMIT/OFFSET will lead to + * inconsistent results at the top-level. (In some cases, where + * the result is ordered, we could relax this restriction. But it + * doesn't currently seem worth expending extra effort to do so.) */ + { + Query *subquery = castNode(Query, rte->subquery); + + if (limit_needed(subquery)) + return; + } break; case RTE_JOIN: |