diff options
| author | Robert Haas <rhaas@postgresql.org> | 2024-08-21 10:14:35 -0400 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2024-08-21 10:14:35 -0400 |
| commit | c01743aa4866e13da2c54e44010abc6d5f986363 (patch) | |
| tree | 7958824608ee01747277b4c7d65d06cb0d8ecde9 /src/backend/optimizer/plan/createplan.c | |
| parent | e22253467942fdb100087787c3e1e3a8620c54b2 (diff) | |
| download | postgresql-c01743aa4866e13da2c54e44010abc6d5f986363.tar.gz postgresql-c01743aa4866e13da2c54e44010abc6d5f986363.zip | |
Show number of disabled nodes in EXPLAIN ANALYZE output.
Now that disable_cost is not included in the cost estimate, there's
no visible sign in EXPLAIN output of which plan nodes are disabled.
Fix that by propagating the number of disabled nodes from Path to
Plan, and then showing it in the EXPLAIN output.
There is some question about whether this is a desirable change.
While I personally believe that it is, it seems best to make it a
separate commit, in case we decide to back out just this part, or
rework it.
Reviewed by Andres Freund, Heikki Linnakangas, and David Rowley.
Discussion: http://postgr.es/m/CA+TgmoZ_+MS+o6NeGK2xyBv-xM+w1AfFVuHE4f_aq6ekHv7YSQ@mail.gmail.com
Diffstat (limited to 'src/backend/optimizer/plan/createplan.c')
| -rw-r--r-- | src/backend/optimizer/plan/createplan.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c index 1960e59ef2f..8e0e5977a9f 100644 --- a/src/backend/optimizer/plan/createplan.c +++ b/src/backend/optimizer/plan/createplan.c @@ -2572,6 +2572,7 @@ create_minmaxagg_plan(PlannerInfo *root, MinMaxAggPath *best_path) 0, NULL, NULL, NULL); /* Must apply correct cost/width data to Limit node */ + plan->disabled_nodes = mminfo->path->disabled_nodes; plan->startup_cost = mminfo->path->startup_cost; plan->total_cost = mminfo->pathcost; plan->plan_rows = 1; @@ -5404,6 +5405,7 @@ order_qual_clauses(PlannerInfo *root, List *clauses) static void copy_generic_path_info(Plan *dest, Path *src) { + dest->disabled_nodes = src->disabled_nodes; dest->startup_cost = src->startup_cost; dest->total_cost = src->total_cost; dest->plan_rows = src->rows; @@ -5419,6 +5421,7 @@ copy_generic_path_info(Plan *dest, Path *src) static void copy_plan_costsize(Plan *dest, Plan *src) { + dest->disabled_nodes = src->disabled_nodes; dest->startup_cost = src->startup_cost; dest->total_cost = src->total_cost; dest->plan_rows = src->plan_rows; @@ -5452,7 +5455,7 @@ label_sort_with_costsize(PlannerInfo *root, Sort *plan, double limit_tuples) cost_sort(&sort_path, root, NIL, lefttree->total_cost, - 0, /* a Plan contains no count of disabled nodes */ + plan->plan.disabled_nodes, lefttree->plan_rows, lefttree->plan_width, 0.0, @@ -6547,11 +6550,12 @@ materialize_finished_plan(Plan *subplan) /* Set cost data */ cost_material(&matpath, - 0, /* a Plan contains no count of disabled nodes */ + subplan->disabled_nodes, subplan->startup_cost, subplan->total_cost, subplan->plan_rows, subplan->plan_width); + matplan->disabled_nodes = subplan->disabled_nodes; matplan->startup_cost = matpath.startup_cost + initplan_cost; matplan->total_cost = matpath.total_cost + initplan_cost; matplan->plan_rows = subplan->plan_rows; |