diff options
| author | Amit Langote <amitlan@postgresql.org> | 2024-11-08 16:29:38 +0900 |
|---|---|---|
| committer | Amit Langote <amitlan@postgresql.org> | 2024-11-08 17:19:35 +0900 |
| commit | a0cdfc8893673d1325f077b79f551aa105f360b8 (patch) | |
| tree | af394a467fbb7d6d8713973dc4b756cae3c5e157 /src/backend/optimizer | |
| parent | b6484ca9535e947a068da01015620dfde0b9b488 (diff) | |
| download | postgresql-a0cdfc8893673d1325f077b79f551aa105f360b8.tar.gz postgresql-a0cdfc8893673d1325f077b79f551aa105f360b8.zip | |
Disallow partitionwise join when collations don't match
If the collation of any join key column doesn’t match the collation of
the corresponding partition key, partitionwise joins can yield incorrect
results. For example, rows that would match under the join key collation
might be located in different partitions due to the partitioning
collation. In such cases, a partitionwise join would yield different
results from a non-partitionwise join, so disallow it in such cases.
Reported-by: Tender Wang <tndrwang@gmail.com>
Author: Jian He <jian.universality@gmail.com>
Reviewed-by: Tender Wang <tndrwang@gmail.com>
Reviewed-by: Junwang Zhao <zhjwpku@gmail.com>
Discussion: https://postgr.es/m/CAHewXNno_HKiQ6PqyLYfuqDtwp7KKHZiH1J7Pqyz0nr+PS2Dwg@mail.gmail.com
Backpatch-through: 12
Diffstat (limited to 'src/backend/optimizer')
| -rw-r--r-- | src/backend/optimizer/util/relnode.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/backend/optimizer/util/relnode.c b/src/backend/optimizer/util/relnode.c index e05b21c884e..610093fe915 100644 --- a/src/backend/optimizer/util/relnode.c +++ b/src/backend/optimizer/util/relnode.c @@ -2188,6 +2188,10 @@ have_partkey_equi_join(PlannerInfo *root, RelOptInfo *joinrel, if (ipk1 != ipk2) continue; + /* Reject if the partition key collation differs from the clause's. */ + if (rel1->part_scheme->partcollation[ipk1] != opexpr->inputcollid) + return false; + /* * The clause allows partitionwise join only if it uses the same * operator family as that specified by the partition key. |