diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-03-24 12:08:48 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-03-24 12:08:48 -0400 |
| commit | 17a28b03645e27d73bf69a95d7569b61e58f06eb (patch) | |
| tree | ea57eb4f285a4f947e6bb99eac960343613cc20e /src/backend/parser/parse_coerce.c | |
| parent | e3a87b4991cc2d00b7a3082abb54c5f12baedfd1 (diff) | |
| download | postgresql-17a28b03645e27d73bf69a95d7569b61e58f06eb.tar.gz postgresql-17a28b03645e27d73bf69a95d7569b61e58f06eb.zip | |
Improve the internal implementation of ereport().
Change all the auxiliary error-reporting routines to return void,
now that we no longer need to pretend they are passing something
useful to errfinish(). While this probably doesn't save anything
significant at the machine-code level, it allows detection of some
additional types of mistakes.
Pass the error location details (__FILE__, __LINE__, PG_FUNCNAME_MACRO)
to errfinish not errstart. This shaves a few cycles off the case where
errstart decides we're not going to emit anything.
Re-implement elog() as a trivial wrapper around ereport(), removing
the separate support infrastructure it used to have. Aside from
getting rid of some now-surplus code, this means that elog() now
really does have exactly the same semantics as ereport(), in particular
that it can skip evaluation work if the message is not to be emitted.
Andres Freund and Tom Lane
Discussion: https://postgr.es/m/CA+fd4k6N8EjNvZpM8nme+y+05mz-SM8Z_BgkixzkA34R+ej0Kw@mail.gmail.com
Diffstat (limited to 'src/backend/parser/parse_coerce.c')
| -rw-r--r-- | src/backend/parser/parse_coerce.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/backend/parser/parse_coerce.c b/src/backend/parser/parse_coerce.c index 645e4aa4ceb..91d4e99d345 100644 --- a/src/backend/parser/parse_coerce.c +++ b/src/backend/parser/parse_coerce.c @@ -1246,15 +1246,15 @@ coerce_to_specific_type(ParseState *pstate, Node *node, * XXX possibly this is more generally useful than coercion errors; * if so, should rename and place with parser_errposition. */ -int +void parser_coercion_errposition(ParseState *pstate, int coerce_location, Node *input_expr) { if (coerce_location >= 0) - return parser_errposition(pstate, coerce_location); + parser_errposition(pstate, coerce_location); else - return parser_errposition(pstate, exprLocation(input_expr)); + parser_errposition(pstate, exprLocation(input_expr)); } |