aboutsummaryrefslogtreecommitdiff
path: root/src/backend/parser/parse_cte.c
diff options
context:
space:
mode:
authorAlvaro Herrera <alvherre@alvh.no-ip.org>2022-08-12 12:05:50 +0200
committerAlvaro Herrera <alvherre@alvh.no-ip.org>2022-08-12 12:05:50 +0200
commit92af9143f13df8c54362ebbd4397cb53f207ff2d (patch)
tree910a3a67d8aeb757872f24578c7052a9698fd09f /src/backend/parser/parse_cte.c
parente7a552f303c56788d52ca4e46490236845662734 (diff)
downloadpostgresql-92af9143f13df8c54362ebbd4397cb53f207ff2d.tar.gz
postgresql-92af9143f13df8c54362ebbd4397cb53f207ff2d.zip
Reject MERGE in CTEs and COPY
The grammar added for MERGE inadvertently made it accepted syntax in places that were not prepared to deal with it -- namely COPY and inside CTEs, but invoking these things with MERGE currently causes assertion failures or weird misbehavior in non-assertion builds. Protect those places by checking for it explicitly until somebody decides to implement it. Reported-by: Alexey Borzov <borz_off@cs.msu.su> Discussion: https://postgr.es/m/17579-82482cd7b267b862@postgresql.org
Diffstat (limited to 'src/backend/parser/parse_cte.c')
-rw-r--r--src/backend/parser/parse_cte.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/backend/parser/parse_cte.c b/src/backend/parser/parse_cte.c
index efb4af706e1..8fc86586085 100644
--- a/src/backend/parser/parse_cte.c
+++ b/src/backend/parser/parse_cte.c
@@ -126,6 +126,13 @@ transformWithClause(ParseState *pstate, WithClause *withClause)
CommonTableExpr *cte = (CommonTableExpr *) lfirst(lc);
ListCell *rest;
+ /* MERGE is allowed by parser, but unimplemented. Reject for now */
+ if (IsA(cte->ctequery, MergeStmt))
+ ereport(ERROR,
+ errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+ errmsg("MERGE not supported in WITH query"),
+ parser_errposition(pstate, cte->location));
+
for_each_cell(rest, withClause->ctes, lnext(withClause->ctes, lc))
{
CommonTableExpr *cte2 = (CommonTableExpr *) lfirst(rest);