diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-02-09 12:02:57 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-02-09 12:02:57 -0500 |
| commit | baf487123ac5e4990cf17a67c90bc4c8adf6e8f1 (patch) | |
| tree | bef7b9ef4f8da432f2590f345da9ac11eb835846 /src/backend/parser/parse_expr.c | |
| parent | 4faea7fdf1768c65af744b5cbeaf201cdd345547 (diff) | |
| download | postgresql-baf487123ac5e4990cf17a67c90bc4c8adf6e8f1.tar.gz postgresql-baf487123ac5e4990cf17a67c90bc4c8adf6e8f1.zip | |
Store the deletion horizon XID for a deleted GIN page on the right page.
Commit b10714080 moved the GinPageSetDeleteXid() call to a spot where
the "page" variable was pointing to the wrong page, causing the XID
to be inserted on a page that's not being deleted, thus allowing later
GinPageIsRecyclable tests to recycle the deleted page too soon.
It might be a good idea to stop using the single "page" variable for
multiple purposes in this function. But for the moment I just moved
the GinPageSetDeleteXid() call down beside the GinPageSetDeleted()
call, which seems like a more logical place for it anyway.
Back-patch to v11, as the faulty patch was. (Fortunately, the bug
hasn't made it into any release yet.)
Discussion: https://postgr.es/m/21620.1581098806@sss.pgh.pa.us
Diffstat (limited to 'src/backend/parser/parse_expr.c')
0 files changed, 0 insertions, 0 deletions