aboutsummaryrefslogtreecommitdiff
path: root/src/backend/parser/parse_utilcmd.c
diff options
context:
space:
mode:
authorAlvaro Herrera <alvherre@alvh.no-ip.org>2017-08-02 18:26:26 -0400
committerAlvaro Herrera <alvherre@alvh.no-ip.org>2017-08-02 18:26:58 -0400
commit060393f2a13651bf53c7626a3587baaf82942023 (patch)
treece890390f6d48cceaa0eb52f2704272cd956128a /src/backend/parser/parse_utilcmd.c
parente5c87d5e1d9cad9019e2c4e4f392ba687bc58d02 (diff)
downloadpostgresql-060393f2a13651bf53c7626a3587baaf82942023.tar.gz
postgresql-060393f2a13651bf53c7626a3587baaf82942023.zip
Fix pg_dump's errno checking for zlib I/O
Some error reports were reporting strerror(errno), which for some error conditions coming from zlib are wrong, resulting in confusing reports such as pg_restore: [compress_io] could not read from input file: Success which makes no sense. To correctly extract the error message we need to use gzerror(), so let's do that. This isn't as comprehensive or as neat as I would like, but at least it should improve things in many common cases. The zlib abstraction in compress_io does not seem to be applied consistently enough; we could perhaps improve that, but it seems master-only material, not a bug fix for back-patching. This problem goes back all the way, but I decided to apply back to 9.4 only, because older branches don't contain commit 14ea89366 which this change depends on. Authors: Vladimir Kunschikov, Álvaro Herrera Discussion: https://postgr.es/m/1498120508308.9826@infotecs.ru
Diffstat (limited to 'src/backend/parser/parse_utilcmd.c')
0 files changed, 0 insertions, 0 deletions