diff options
| author | Alexander Korotkov <akorotkov@postgresql.org> | 2024-05-13 00:00:21 +0300 |
|---|---|---|
| committer | Alexander Korotkov <akorotkov@postgresql.org> | 2024-05-13 00:00:21 +0300 |
| commit | 3ca43dbbb67fbfb96dec8de2e268b96790555148 (patch) | |
| tree | 27ab10f579795e11066f08deeb8a7585a10b3b98 /src/backend/parser/parse_utilcmd.c | |
| parent | cff4e5a36bfe1191a688c5eaff7ba095588ba732 (diff) | |
| download | postgresql-3ca43dbbb67fbfb96dec8de2e268b96790555148.tar.gz postgresql-3ca43dbbb67fbfb96dec8de2e268b96790555148.zip | |
Add permission check for MERGE/SPLIT partition operations
Currently, we check only owner permission for the parent table before
MERGE/SPLIT partition operations. This leads to a security hole when users
can get access to the data of partitions without permission. This commit
fixes this problem by requiring owner permission on all the partitions
involved.
Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/0520c72e-8d97-245e-53f9-173beca2ab2e%40gmail.com
Author: Dmitry Koval, Alexander Korotkov
Diffstat (limited to 'src/backend/parser/parse_utilcmd.c')
| -rw-r--r-- | src/backend/parser/parse_utilcmd.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c index 6520bf9baa5..0598e897d90 100644 --- a/src/backend/parser/parse_utilcmd.c +++ b/src/backend/parser/parse_utilcmd.c @@ -3456,6 +3456,11 @@ checkPartition(Relation rel, Oid partRelOid) RelationGetRelationName(partRel), RelationGetRelationName(rel)))); + /* Permissions checks */ + if (!object_ownercheck(RelationRelationId, RelationGetRelid(partRel), GetUserId())) + aclcheck_error(ACLCHECK_NOT_OWNER, get_relkind_objtype(partRel->rd_rel->relkind), + RelationGetRelationName(partRel)); + relation_close(partRel, AccessShareLock); } |