diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2022-01-13 17:49:26 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2022-01-13 17:49:26 -0500 |
| commit | ca14c4184b55cbe2fa79c87174b8064fc5f90874 (patch) | |
| tree | 6b9c115e8238cf4cbce73be9d7a2a234826f48fb /src/backend/parser/parse_utilcmd.c | |
| parent | 2180833ba90e9657a7e622b419194763890c8a6d (diff) | |
| download | postgresql-ca14c4184b55cbe2fa79c87174b8064fc5f90874.tar.gz postgresql-ca14c4184b55cbe2fa79c87174b8064fc5f90874.zip | |
Fix ruleutils.c's dumping of whole-row Vars in more contexts.
Commit 7745bc352 intended to ensure that whole-row Vars would be
printed with "::type" decoration in all contexts where plain
"var.*" notation would result in star-expansion, notably in
ROW() and VALUES() constructs. However, it missed the case of
INSERT with a single-row VALUES, as reported by Timur Khanjanov.
Nosing around ruleutils.c, I found a second oversight: the
code for RowCompareExpr generates ROW() notation without benefit
of an actual RowExpr, and naturally it wasn't in sync :-(.
(The code for FieldStore also does this, but we don't expect that
to generate strictly parsable SQL anyway, so I left it alone.)
Back-patch to all supported branches.
Discussion: https://postgr.es/m/efaba6f9-4190-56be-8ff2-7a1674f9194f@intrans.baku.az
Diffstat (limited to 'src/backend/parser/parse_utilcmd.c')
0 files changed, 0 insertions, 0 deletions