diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2024-07-23 14:58:30 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2024-07-23 15:07:10 +0200 |
| commit | d3cc5ffe81f64c6418ba9b18a9db32392f8027e6 (patch) | |
| tree | f6d60395f85e4b0ef327b1939aedee415168f03e /src/backend/postmaster/launch_backend.c | |
| parent | 840b3b5b4ee90ce8b692519e534dfb015d89fe8f (diff) | |
| download | postgresql-d3cc5ffe81f64c6418ba9b18a9db32392f8027e6.tar.gz postgresql-d3cc5ffe81f64c6418ba9b18a9db32392f8027e6.zip | |
Move extern declarations for EXEC_BACKEND to header files
This fixes warnings from -Wmissing-variable-declarations (not yet part
of the standard warning options) under EXEC_BACKEND. The
NON_EXEC_STATIC variables need a suitable declaration in a header file
under EXEC_BACKEND.
Also fix the inconsistent application of the volatile qualifier for
PMSignalState, which was revealed by this change.
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/flat/e0a62134-83da-4ba4-8cdb-ceb0111c95ce@eisentraut.org
Diffstat (limited to 'src/backend/postmaster/launch_backend.c')
| -rw-r--r-- | src/backend/postmaster/launch_backend.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/src/backend/postmaster/launch_backend.c b/src/backend/postmaster/launch_backend.c index f9b24b79899..e9fc9827878 100644 --- a/src/backend/postmaster/launch_backend.c +++ b/src/backend/postmaster/launch_backend.c @@ -114,7 +114,7 @@ typedef struct PROC_HDR *ProcGlobal; PGPROC *AuxiliaryProcs; PGPROC *PreparedXactProcs; - PMSignalData *PMSignalState; + volatile PMSignalData *PMSignalState; pid_t PostmasterPid; TimestampTz PgStartTime; TimestampTz PgReloadTime; @@ -668,16 +668,6 @@ SubPostmasterMain(int argc, char *argv[]) pg_unreachable(); /* main_fn never returns */ } -/* - * The following need to be available to the save/restore_backend_variables - * functions. They are marked NON_EXEC_STATIC in their home modules. - */ -extern slock_t *ProcStructLock; -extern PGPROC *AuxiliaryProcs; -extern PMSignalData *PMSignalState; -extern pg_time_t first_syslogger_file_time; -extern struct bkend *ShmemBackendArray; - #ifndef WIN32 #define write_inheritable_socket(dest, src, childpid) ((*(dest) = (src)), true) #define read_inheritable_socket(dest, src) (*(dest) = *(src)) |