diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2016-11-10 16:16:33 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2016-11-10 16:16:33 -0500 |
| commit | 24aef33804be5d7d71bc3932ced3407fce71e354 (patch) | |
| tree | c2e77995c997577d73bf45c7ef99e00e7de47d4a /src/backend/regex/regcomp.c | |
| parent | 530f8065243b185e56c70ab317a9b40964b4ad00 (diff) | |
| download | postgresql-24aef33804be5d7d71bc3932ced3407fce71e354.tar.gz postgresql-24aef33804be5d7d71bc3932ced3407fce71e354.zip | |
Cleanup of rewriter and planner handling of Query.hasRowSecurity flag.
Be sure to pull up the subquery's hasRowSecurity flag when flattening a
subquery in pull_up_simple_subquery(). This isn't a bug today because
we don't look at the hasRowSecurity flag during planning, but it could
easily be a bug tomorrow.
Likewise, make rewriteRuleAction() pull up the hasRowSecurity flag when
absorbing RTEs from a rule action. This isn't a bug either, for the
opposite reason: the flag should never be set yet. But again, it seems
like good future proofing.
Add a comment explaining why rewriteTargetView() should *not* set
hasRowSecurity when adding stuff to securityQuals.
Improve some nearby comments about securityQuals processing, and document
that field more completely in parsenodes.h.
Patch by me, analysis by Dean Rasheed.
Discussion: <CAEZATCXZ8tb2DV6f=bkhsMV6u_gRcZ0CZBw2J-qU84RxSukZog@mail.gmail.com>
Diffstat (limited to 'src/backend/regex/regcomp.c')
0 files changed, 0 insertions, 0 deletions