aboutsummaryrefslogtreecommitdiff
path: root/src/backend/regex/regexec.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2010-01-25 01:58:19 +0000
committerTom Lane <tgl@sss.pgh.pa.us>2010-01-25 01:58:19 +0000
commit96b0da67ff82268d6d2dc6eeabaa277ba4a2fab4 (patch)
treeb2acb82bc37c6250ca3380c3f9abef2be25059ab /src/backend/regex/regexec.c
parent5244ed40cfc9a6234d2d291f61884e80f8330d03 (diff)
downloadpostgresql-96b0da67ff82268d6d2dc6eeabaa277ba4a2fab4.tar.gz
postgresql-96b0da67ff82268d6d2dc6eeabaa277ba4a2fab4.zip
Apply Tcl_Init() to the "hold" interpreter created by pltcl.
You might think this is unnecessary since that interpreter is never used to run code --- but it turns out that's wrong. As of Tcl 8.5, the "clock" command (alone among builtin Tcl commands) is partially implemented by loaded-on-demand Tcl code, which means that it fails if there's not unknown-command support, and also that it's impossible to run it directly in a safe interpreter. The way they get around the latter is that Tcl_CreateSlave() automatically sets up an alias command that forwards any execution of "clock" in a safe slave interpreter to its parent interpreter. Thus, when attempting to execute "clock" in trusted pltcl, the command actually executes in the "hold" interpreter, where it will fail if unknown-command support hasn't been introduced by sourcing the standard init.tcl script, which is done by Tcl_Init(). (This is a pretty dubious design decision on the Tcl boys' part, if you ask me ... but they didn't.) Back-patch all the way. It's not clear that anyone would try to use ancient versions of pltcl with a recent Tcl, but it's not clear they wouldn't, either. Also add a regression test using "clock", in branches that have regression test support for pltcl. Per recent trouble report from Kyle Bateman.
Diffstat (limited to 'src/backend/regex/regexec.c')
0 files changed, 0 insertions, 0 deletions