diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2022-01-23 12:51:38 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2022-01-23 12:51:38 -0500 |
| commit | 353708e1fb2d8b1a34f6da2c25d4bb6633cf4493 (patch) | |
| tree | f94ce7c1ca2162319b6a541c4cbafeafddf3b06d /src/backend/replication/logical/decode.c | |
| parent | dc43fc9b3aa3e0fa9c84faddad6d301813580f88 (diff) | |
| download | postgresql-353708e1fb2d8b1a34f6da2c25d4bb6633cf4493.tar.gz postgresql-353708e1fb2d8b1a34f6da2c25d4bb6633cf4493.zip | |
Clean up recent Coverity complaints.
Commit 5c649fe15 introduced a memory leak into pg_basebackup's
parse_compress_options. (I simplified nearby code while at it.)
Commit 9a974cbcb introduced a memory leak into pg_dump's
binary_upgrade_set_pg_class_oids.
Coverity also complained about a call of SnapBuildProcessChange that
ignored the result, unlike every other call of that function. This
is evidently intentional, so add a (void) cast to indicate that.
(It's also old, dating to b89e15105; I suppose the reason it showed
up now is 7a5f6b474's recent rearrangement of nearby code.)
Diffstat (limited to 'src/backend/replication/logical/decode.c')
| -rw-r--r-- | src/backend/replication/logical/decode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/replication/logical/decode.c b/src/backend/replication/logical/decode.c index 9b450c9f90e..3fb5a92a1a1 100644 --- a/src/backend/replication/logical/decode.c +++ b/src/backend/replication/logical/decode.c @@ -498,7 +498,7 @@ heap_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf) if (!TransactionIdIsValid(xid)) break; - SnapBuildProcessChange(builder, xid, buf->origptr); + (void) SnapBuildProcessChange(builder, xid, buf->origptr); ReorderBufferXidSetCatalogChanges(ctx->reorder, xid, buf->origptr); break; |