diff options
| author | Andres Freund <andres@anarazel.de> | 2020-03-24 12:14:18 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2020-03-24 12:15:03 -0700 |
| commit | 112b006fe79b6fe84647df84a07c201e5a7b1635 (patch) | |
| tree | b2cce5846b4765705b37d96ffb2bdfd10f82542d /src/backend/replication/logical/reorderbuffer.c | |
| parent | f15ace793578d96d70dad1e613293ae3eab92503 (diff) | |
| download | postgresql-112b006fe79b6fe84647df84a07c201e5a7b1635.tar.gz postgresql-112b006fe79b6fe84647df84a07c201e5a7b1635.zip | |
logical decoding: Remove TODO about unnecessary optimization.
Measurements show, and intuition agrees, that there's currently no
known cases where adding a fastpath to avoid allocating / ordering a
heap for a single transaction is worthwhile.
Author: Dilip Kumar
Discussion: https://postgr.es/m/CAFiTN-sp701wvzvnLQJGk7JDqrFM8f--97-ihbwkU8qvn=p8nw@mail.gmail.com
Diffstat (limited to 'src/backend/replication/logical/reorderbuffer.c')
| -rw-r--r-- | src/backend/replication/logical/reorderbuffer.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c index 481277a1fd8..4594cf95097 100644 --- a/src/backend/replication/logical/reorderbuffer.c +++ b/src/backend/replication/logical/reorderbuffer.c @@ -1037,11 +1037,6 @@ ReorderBufferIterTXNInit(ReorderBuffer *rb, ReorderBufferTXN *txn, nr_txns++; } - /* - * TODO: Consider adding fastpath for the rather common nr_txns=1 case, no - * need to allocate/build a heap then. - */ - /* allocate iteration state */ state = (ReorderBufferIterTXNState *) MemoryContextAllocZero(rb->context, |