diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2020-05-13 15:31:14 -0400 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2020-05-13 15:31:14 -0400 |
| commit | 17cc133f017cb13737e23ce0da4415daf2c34cc3 (patch) | |
| tree | 45bd1e33f52902f315aa6364fd9fdf1ff152403a /src/backend/replication | |
| parent | 81ca8686305c4c62d723ab224ad5c414f350a3a0 (diff) | |
| download | postgresql-17cc133f017cb13737e23ce0da4415daf2c34cc3.tar.gz postgresql-17cc133f017cb13737e23ce0da4415daf2c34cc3.zip | |
Dial back -Wimplicit-fallthrough to level 3
The additional pain from level 4 is excessive for the gain.
Also revert all the source annotation changes to their original
wordings, to avoid back-patching pain.
Discussion: https://postgr.es/m/31166.1589378554@sss.pgh.pa.us
Diffstat (limited to 'src/backend/replication')
| -rw-r--r-- | src/backend/replication/logical/reorderbuffer.c | 2 | ||||
| -rw-r--r-- | src/backend/replication/walreceiver.c | 2 | ||||
| -rw-r--r-- | src/backend/replication/walreceiverfuncs.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c index 02f0199ba1b..4594cf95097 100644 --- a/src/backend/replication/logical/reorderbuffer.c +++ b/src/backend/replication/logical/reorderbuffer.c @@ -1589,7 +1589,7 @@ ReorderBufferCommit(ReorderBuffer *rb, TransactionId xid, change = specinsert; change->action = REORDER_BUFFER_CHANGE_INSERT; - /* FALLTHROUGH */ + /* intentionally fall through */ case REORDER_BUFFER_CHANGE_INSERT: case REORDER_BUFFER_CHANGE_UPDATE: case REORDER_BUFFER_CHANGE_DELETE: diff --git a/src/backend/replication/walreceiver.c b/src/backend/replication/walreceiver.c index faca7327134..d69fb90132d 100644 --- a/src/backend/replication/walreceiver.c +++ b/src/backend/replication/walreceiver.c @@ -215,7 +215,7 @@ WalReceiverMain(void) case WALRCV_STOPPING: /* If we've already been requested to stop, don't start up. */ walrcv->walRcvState = WALRCV_STOPPED; - /* FALLTHROUGH */ + /* fall through */ case WALRCV_STOPPED: SpinLockRelease(&walrcv->mutex); diff --git a/src/backend/replication/walreceiverfuncs.c b/src/backend/replication/walreceiverfuncs.c index bf68852bf0c..4afad83539c 100644 --- a/src/backend/replication/walreceiverfuncs.c +++ b/src/backend/replication/walreceiverfuncs.c @@ -183,7 +183,7 @@ ShutdownWalRcv(void) case WALRCV_WAITING: case WALRCV_RESTARTING: walrcv->walRcvState = WALRCV_STOPPING; - /* FALLTHROUGH */ + /* fall through */ case WALRCV_STOPPING: walrcvpid = walrcv->pid; break; |