diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2004-01-14 23:01:55 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2004-01-14 23:01:55 +0000 |
| commit | cfd7fb7ed4b66da97f88338d991843fa7e2fe59d (patch) | |
| tree | f433f1281eba10a7ab2e563fa39eaf3228df32e8 /src/backend/rewrite/rewriteDefine.c | |
| parent | 01d320d421b3f82de799e86e8b9adac27c2f9a26 (diff) | |
| download | postgresql-cfd7fb7ed4b66da97f88338d991843fa7e2fe59d.tar.gz postgresql-cfd7fb7ed4b66da97f88338d991843fa7e2fe59d.zip | |
Fix permission-checking bug reported by Tim Burgess 10-Feb-03 (this time
for sure...). Rather than relying on the query context of a rangetable
entry to identify what permissions it wants checked, store a full AclMode
mask in each RTE, and check exactly those bits. This allows an RTE
specifying, say, INSERT privilege on a view to be copied into a derived
UPDATE query without changing meaning. Per recent discussion thread.
initdb forced due to change of stored rule representation.
Diffstat (limited to 'src/backend/rewrite/rewriteDefine.c')
| -rw-r--r-- | src/backend/rewrite/rewriteDefine.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/backend/rewrite/rewriteDefine.c b/src/backend/rewrite/rewriteDefine.c index 90497cf5b88..f1cbe96fd2a 100644 --- a/src/backend/rewrite/rewriteDefine.c +++ b/src/backend/rewrite/rewriteDefine.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/rewrite/rewriteDefine.c,v 1.91 2003/11/29 19:51:55 pgsql Exp $ + * $PostgreSQL: pgsql/src/backend/rewrite/rewriteDefine.c,v 1.92 2004/01/14 23:01:55 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -34,7 +34,7 @@ static void setRuleCheckAsUser(Query *qry, AclId userid); -static bool setRuleCheckAsUser_walker(Node *node, Oid *context); +static bool setRuleCheckAsUser_walker(Node *node, AclId *context); /* @@ -494,8 +494,8 @@ DefineQueryRewrite(RuleStmt *stmt) * Note: for a view (ON SELECT rule), the checkAsUser field of the *OLD* * RTE entry will be overridden when the view rule is expanded, and the * checkAsUser field of the *NEW* entry is irrelevant because that entry's - * checkFor bits will never be set. However, for other types of rules it's - * important to set these fields to match the rule owner. So we just set + * requiredPerms bits will always be zero. However, for other types of rules + * it's important to set these fields to match the rule owner. So we just set * them always. */ static void @@ -528,7 +528,7 @@ setRuleCheckAsUser(Query *qry, AclId userid) * Expression-tree walker to find sublink queries */ static bool -setRuleCheckAsUser_walker(Node *node, Oid *context) +setRuleCheckAsUser_walker(Node *node, AclId *context) { if (node == NULL) return false; |