aboutsummaryrefslogtreecommitdiff
path: root/src/backend/rewrite/rewriteHandler.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2021-02-07 12:54:08 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2021-02-07 12:54:08 -0500
commitac1df003f253cfeff700558a55274d709340f829 (patch)
treed78d2be4e203c1c806fe50cf4b0907bf83192e67 /src/backend/rewrite/rewriteHandler.c
parent9c89c4bd8d00742b569e7b0e9a49babc7da519d5 (diff)
downloadpostgresql-ac1df003f253cfeff700558a55274d709340f829.tar.gz
postgresql-ac1df003f253cfeff700558a55274d709340f829.zip
Revert "Propagate CTE property flags when copying a CTE list into a rule."
This reverts commit ed290896335414c6c069b9ccae1f3dcdd2fac6ba and equivalent back-branch commits. The issue is subtler than I thought, and it's far from new, so just before a release deadline is no time to be fooling with it. We'll consider what to do at a bit more leisure. Discussion: https://postgr.es/m/CAJcOf-fAdj=nDKMsRhQzndm-O13NY4dL6xGcEvdX5Xvbbi0V7g@mail.gmail.com
Diffstat (limited to 'src/backend/rewrite/rewriteHandler.c')
-rw-r--r--src/backend/rewrite/rewriteHandler.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/src/backend/rewrite/rewriteHandler.c b/src/backend/rewrite/rewriteHandler.c
index 89c579ce3dd..efecb6e1d81 100644
--- a/src/backend/rewrite/rewriteHandler.c
+++ b/src/backend/rewrite/rewriteHandler.c
@@ -530,9 +530,6 @@ rewriteRuleAction(Query *parsetree,
*
* This could possibly be fixed by using some sort of internally
* generated ID, instead of names, to link CTE RTEs to their CTEs.
- * However, decompiling the results would be quite confusing; note the
- * merge of hasRecursive flags below, which could change the apparent
- * semantics of such redundantly-named CTEs.
*/
foreach(lc, parsetree->cteList)
{
@@ -554,9 +551,6 @@ rewriteRuleAction(Query *parsetree,
/* OK, it's safe to combine the CTE lists */
sub_action->cteList = list_concat(sub_action->cteList,
copyObject(parsetree->cteList));
- /* ... and don't forget about the associated flags */
- sub_action->hasRecursive |= parsetree->hasRecursive;
- sub_action->hasModifyingCTE |= parsetree->hasModifyingCTE;
}
/*