diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2023-05-15 10:31:14 +1200 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2023-05-15 10:31:14 +1200 |
| commit | 319bae9a8da66678d80d862440e54cebc7b1cc24 (patch) | |
| tree | 95120095ef209574cc915734034571d957e28466 /src/backend/storage/file/fd.c | |
| parent | 4d5105a684ba20bf6a98e6ae48224fe93382c040 (diff) | |
| download | postgresql-319bae9a8da66678d80d862440e54cebc7b1cc24.tar.gz postgresql-319bae9a8da66678d80d862440e54cebc7b1cc24.zip | |
Rename io_direct to debug_io_direct.
Give the new GUC introduced by d4e71df6 a name that is clearly not
intended for mainstream use quite yet.
Future proposals would drop the prefix only after adding infrastructure
to make it efficient. Having the switch in the tree sooner is good
because it might lead to new discoveries about the hazards awaiting us
on a wide range of systems, but that name was too enticing and could
lead to cross-version confusion in future, per complaints from Noah and
Justin.
Suggested-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Justin Pryzby <pryzby@telsasoft.com> (the idea, not the patch)
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> (ditto)
Discussion: https://postgr.es/m/20230430041106.GA2268796%40rfd.leadboat.com
Diffstat (limited to 'src/backend/storage/file/fd.c')
| -rw-r--r-- | src/backend/storage/file/fd.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c index 4f86d44d6e3..173476789c7 100644 --- a/src/backend/storage/file/fd.c +++ b/src/backend/storage/file/fd.c @@ -3844,7 +3844,7 @@ check_io_direct(char **newval, void **extra, GucSource source) #if PG_O_DIRECT == 0 if (strcmp(*newval, "") != 0) { - GUC_check_errdetail("io_direct is not supported on this platform."); + GUC_check_errdetail("debug_io_direct is not supported on this platform."); result = false; } flags = 0; @@ -3859,7 +3859,7 @@ check_io_direct(char **newval, void **extra, GucSource source) if (!SplitGUCList(rawstring, ',', &elemlist)) { GUC_check_errdetail("invalid list syntax in parameter \"%s\"", - "io_direct"); + "debug_io_direct"); pfree(rawstring); list_free(elemlist); return false; @@ -3891,14 +3891,14 @@ check_io_direct(char **newval, void **extra, GucSource source) #if XLOG_BLCKSZ < PG_IO_ALIGN_SIZE if (result && (flags & (IO_DIRECT_WAL | IO_DIRECT_WAL_INIT))) { - GUC_check_errdetail("io_direct is not supported for WAL because XLOG_BLCKSZ is too small"); + GUC_check_errdetail("debug_io_direct is not supported for WAL because XLOG_BLCKSZ is too small"); result = false; } #endif #if BLCKSZ < PG_IO_ALIGN_SIZE if (result && (flags & IO_DIRECT_DATA)) { - GUC_check_errdetail("io_direct is not supported for data because BLCKSZ is too small"); + GUC_check_errdetail("debug_io_direct is not supported for data because BLCKSZ is too small"); result = false; } #endif |