aboutsummaryrefslogtreecommitdiff
path: root/src/backend/storage
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2018-04-10 18:34:40 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2018-04-10 18:34:40 -0400
commit2224d1ce144789bf108382f4fdec9f9e9dcf385a (patch)
tree90f39c640f8b2ff47247ce522872b9a9820da1f8 /src/backend/storage
parentc5261348a6ff33c7398287e9c4efca210d68b9fd (diff)
downloadpostgresql-2224d1ce144789bf108382f4fdec9f9e9dcf385a.tar.gz
postgresql-2224d1ce144789bf108382f4fdec9f9e9dcf385a.zip
Fix incorrect close() call in dsm_impl_mmap().
One improbable error-exit path in this function used close() where it should have used CloseTransientFile(). This is unlikely to be hit in the field, and I think the consequences wouldn't be awful (just an elog(LOG) bleat later). But a bug is a bug, so back-patch to 9.4 where this code came in. Pan Bian Discussion: https://postgr.es/m/152056616579.4966.583293218357089052@wrigleys.postgresql.org
Diffstat (limited to 'src/backend/storage')
-rw-r--r--src/backend/storage/ipc/dsm_impl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/storage/ipc/dsm_impl.c b/src/backend/storage/ipc/dsm_impl.c
index 62d26ba70fc..661ef27c75b 100644
--- a/src/backend/storage/ipc/dsm_impl.c
+++ b/src/backend/storage/ipc/dsm_impl.c
@@ -923,7 +923,7 @@ dsm_impl_mmap(dsm_op op, dsm_handle handle, Size request_size,
/* Back out what's already been done. */
save_errno = errno;
- close(fd);
+ CloseTransientFile(fd);
if (op == DSM_OP_CREATE)
unlink(name);
errno = save_errno;