diff options
| author | Joe Conway <mail@joeconway.com> | 2022-03-28 15:10:04 -0400 |
|---|---|---|
| committer | Joe Conway <mail@joeconway.com> | 2022-03-28 15:10:04 -0400 |
| commit | 6198420ad8a72e37f4fe4964616b17e0fd33b808 (patch) | |
| tree | 48b9bf9c3997840958f3290ff8a1a2330a5b55b8 /src/backend/utils/adt/acl.c | |
| parent | 79de9842ab03259325ee4055fb0a7ebd2e4372ff (diff) | |
| download | postgresql-6198420ad8a72e37f4fe4964616b17e0fd33b808.tar.gz postgresql-6198420ad8a72e37f4fe4964616b17e0fd33b808.zip | |
Use has_privs_for_roles for predefined role checks
Generally if a role is granted membership to another role with NOINHERIT
they must use SET ROLE to access the privileges of that role, however
with predefined roles the membership and privilege is conflated. Fix that
by replacing is_member_of_role with has_privs_for_role for predefined
roles. Patch does not remove is_member_of_role from acl.h, but it does
add a warning not to use that function for privilege checking. Not
backpatched based on hackers list discussion.
Author: Joshua Brindle
Reviewed-by: Stephen Frost, Nathan Bossart, Joe Conway
Discussion: https://postgr.es/m/flat/CAGB+Vh4Zv_TvKt2tv3QNS6tUM_F_9icmuj0zjywwcgVi4PAhFA@mail.gmail.com
Diffstat (limited to 'src/backend/utils/adt/acl.c')
| -rw-r--r-- | src/backend/utils/adt/acl.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/backend/utils/adt/acl.c b/src/backend/utils/adt/acl.c index 5d939de3da7..83cf7ac9ff9 100644 --- a/src/backend/utils/adt/acl.c +++ b/src/backend/utils/adt/acl.c @@ -4859,6 +4859,8 @@ has_privs_of_role(Oid member, Oid role) * Is member a member of role (directly or indirectly)? * * This is defined to recurse through roles regardless of rolinherit. + * + * Do not use this for privilege checking, instead use has_privs_of_role() */ bool is_member_of_role(Oid member, Oid role) @@ -4899,6 +4901,8 @@ check_is_member_of_role(Oid member, Oid role) * * This is identical to is_member_of_role except we ignore superuser * status. + * + * Do not use this for privilege checking, instead use has_privs_of_role() */ bool is_member_of_role_nosuper(Oid member, Oid role) |