aboutsummaryrefslogtreecommitdiff
path: root/src/backend/utils/adt/jsonb_util.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2014-12-10 19:06:27 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2014-12-10 19:06:27 -0500
commit24688f4e5a7d5fadde0e43a5b123432d81577d82 (patch)
tree8d42cf1bbf30e59ea8461464c9ecec625d02fd1c /src/backend/utils/adt/jsonb_util.c
parente39250c644ea7cd3904e4e24570db21a209cf97f (diff)
downloadpostgresql-24688f4e5a7d5fadde0e43a5b123432d81577d82.tar.gz
postgresql-24688f4e5a7d5fadde0e43a5b123432d81577d82.zip
Fix minor thinko in convertToJsonb().
The amount of space to reserve for the value's varlena header is VARHDRSZ, not sizeof(VARHDRSZ). The latter coding accidentally failed to fail because of the way the VARHDRSZ macro is currently defined; but if we ever change it to return size_t (as one might reasonably expect it to do), convertToJsonb() would have failed. Spotted by Mark Dilger.
Diffstat (limited to 'src/backend/utils/adt/jsonb_util.c')
-rw-r--r--src/backend/utils/adt/jsonb_util.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/adt/jsonb_util.c b/src/backend/utils/adt/jsonb_util.c
index 2ff85396d01..c62941baa7b 100644
--- a/src/backend/utils/adt/jsonb_util.c
+++ b/src/backend/utils/adt/jsonb_util.c
@@ -1377,7 +1377,7 @@ convertToJsonb(JsonbValue *val)
initStringInfo(&buffer);
/* Make room for the varlena header */
- reserveFromBuffer(&buffer, sizeof(VARHDRSZ));
+ reserveFromBuffer(&buffer, VARHDRSZ);
convertJsonbValue(&buffer, &jentry, val, 0);