diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-07-03 19:01:21 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-07-03 19:01:21 -0400 |
| commit | 9233624b128b41fd410712a7223821878f1943b0 (patch) | |
| tree | f46c60a940fd51383c02feb99d62547e255236f1 /src/backend/utils/adt/jsonb_util.c | |
| parent | cfe89f5e6b7874e89dac7d9511b1894a7d033870 (diff) | |
| download | postgresql-9233624b128b41fd410712a7223821878f1943b0.tar.gz postgresql-9233624b128b41fd410712a7223821878f1943b0.zip | |
Clamp total-tuples estimates for foreign tables to ensure planner sanity.
After running GetForeignRelSize for a foreign table, adjust rel->tuples
to be at least as large as rel->rows. This prevents bizarre behavior
in estimate_num_groups() and perhaps other places, especially in the
scenario where rel->tuples is zero because pg_class.reltuples is
(suggesting that ANALYZE has never been run for the table). As things
stood, we'd end up estimating one group out of any GROUP BY on such a
table, whereas the default group-count estimate is more likely to result
in a sane plan.
Also, clarify in the documentation that GetForeignRelSize has the option
to override the rel->tuples value if it has a better idea of what to use
than what is in pg_class.reltuples.
Per report from Jeff Janes. Back-patch to all supported branches.
Patch by me; thanks to Etsuro Fujita for review
Discussion: https://postgr.es/m/CAMkU=1xNo9cnan+Npxgz0eK7394xmjmKg-QEm8wYG9P5-CcaqQ@mail.gmail.com
Diffstat (limited to 'src/backend/utils/adt/jsonb_util.c')
0 files changed, 0 insertions, 0 deletions