diff options
author | Robert Haas <rhaas@postgresql.org> | 2015-03-19 10:56:34 -0400 |
---|---|---|
committer | Robert Haas <rhaas@postgresql.org> | 2015-03-19 11:04:09 -0400 |
commit | bf740ce9e5d82612889d131f34c079215973ca00 (patch) | |
tree | 18c630fa140fd564442c7761eeb0a028bc216d2e /src/backend/utils/adt/misc.c | |
parent | 417f78a5178815d8c10f86b1561c88c45c53c2d2 (diff) | |
download | postgresql-bf740ce9e5d82612889d131f34c079215973ca00.tar.gz postgresql-bf740ce9e5d82612889d131f34c079215973ca00.zip |
Fix status reporting for terminated bgworkers that were never started.
Previously, GetBackgroundWorkerPid() would return BGWH_NOT_YET_STARTED
if the slot used for the worker registration had not been reused by
unrelated activity, and BGWH_STOPPED if it had. Either way, a process
that had requested notification when the state of one of its
background workers changed did not receive such notifications. Fix
things so that GetBackgroundWorkerPid() always returns BGWH_STOPPED in
this situation, so that we do not erroneously give waiters the
impression that the worker will eventually be started; and send
notifications just as we would if the process terminated after having
been started, so that it's possible to wait for the postmaster to
process a worker termination request without polling.
Discovered by Amit Kapila during testing of parallel sequential scan.
Analysis and fix by me. Back-patch to 9.4; there may not be anyone
relying on this interface yet, but if anyone is, the new behavior is a
clear improvement.
Diffstat (limited to 'src/backend/utils/adt/misc.c')
0 files changed, 0 insertions, 0 deletions