diff options
author | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2023-08-29 09:09:40 +0300 |
---|---|---|
committer | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2023-08-29 09:12:24 +0300 |
commit | 3d895f95a0209969dddd7534747555ed8e3c1a79 (patch) | |
tree | 66276fdb810015896da2a7d95c26b19a8db14f85 /src/backend/utils/adt/network_spgist.c | |
parent | 9b2a41db1cc007df304bf7874813e6ab78b9a830 (diff) | |
download | postgresql-3d895f95a0209969dddd7534747555ed8e3c1a79.tar.gz postgresql-3d895f95a0209969dddd7534747555ed8e3c1a79.zip |
Initialize ListenSocket array earlier.
After commit b0bea38705, syslogger prints 63 warnings about failing to
close a listen socket at postmaster startup. That's because the
syslogger process forks before the ListenSockets array is initialized,
so ClosePostmasterPorts() calls "close(0)" 64 times. The first call
succeeds, because fd 0 is stdin.
This has been like this since commit 9a86f03b4e in version 13, which
moved the SysLogger_Start() call to before initializing ListenSockets.
We just didn't notice until commit b0bea38705 added the LOG message.
Reported by Michael Paquier and Jeff Janes.
Author: Michael Paquier
Discussion: https://www.postgresql.org/message-id/ZOvvuQe0rdj2slA9%40paquier.xyz
Discussion: https://www.postgresql.org/message-id/ZO0fgDwVw2SUJiZx@paquier.xyz#482670177eb4eaf4c9f03c1eed963e5f
Backpatch-through: 13
Diffstat (limited to 'src/backend/utils/adt/network_spgist.c')
0 files changed, 0 insertions, 0 deletions