diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2007-07-09 16:14:06 +0000 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2007-07-09 16:14:06 +0000 |
commit | 3df98a9e2fcada34de3ec8325f83b82426014c6d (patch) | |
tree | aa6a65a609aa462e43f25b2305d005b39058304c /src/backend/utils/adt/numeric.c | |
parent | 809b38ce27742b1e47acad44c3742ea5af6add8d (diff) | |
download | postgresql-3df98a9e2fcada34de3ec8325f83b82426014c6d.tar.gz postgresql-3df98a9e2fcada34de3ec8325f83b82426014c6d.zip |
Fix stddev_pop(numeric) and var_pop(numeric), which were incorrectly producing
the same outputs as stddev_samp() and var_samp() respectively.
Diffstat (limited to 'src/backend/utils/adt/numeric.c')
-rw-r--r-- | src/backend/utils/adt/numeric.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/backend/utils/adt/numeric.c b/src/backend/utils/adt/numeric.c index 71a2e491868..65530f9dd8e 100644 --- a/src/backend/utils/adt/numeric.c +++ b/src/backend/utils/adt/numeric.c @@ -14,7 +14,7 @@ * Copyright (c) 1998-2006, PostgreSQL Global Development Group * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/utils/adt/numeric.c,v 1.96.2.1 2007/06/09 15:52:38 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/utils/adt/numeric.c,v 1.96.2.2 2007/07/09 16:14:05 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -2274,7 +2274,10 @@ numeric_stddev_internal(ArrayType *transarray, } else { - mul_var(&vN, &vNminus1, &vNminus1, 0); /* N * (N - 1) */ + if (sample) + mul_var(&vN, &vNminus1, &vNminus1, 0); /* N * (N - 1) */ + else + mul_var(&vN, &vN, &vNminus1, 0); /* N * N */ rscale = select_div_scale(&vsumX2, &vNminus1); div_var(&vsumX2, &vNminus1, &vsumX, rscale, true); /* variance */ if (!variance) |