aboutsummaryrefslogtreecommitdiff
path: root/src/backend/utils/adt/numeric.c
diff options
context:
space:
mode:
authorDean Rasheed <dean.a.rasheed@gmail.com>2021-01-05 11:15:28 +0000
committerDean Rasheed <dean.a.rasheed@gmail.com>2021-01-05 11:15:28 +0000
commitbc43b7c2c06c32264efe79d0b86abd41236f1d5b (patch)
tree0275ee6fd9138f641745d28777e0face05240040 /src/backend/utils/adt/numeric.c
parent5a3574d7b33480de51692962e6fd25d00c05718a (diff)
downloadpostgresql-bc43b7c2c06c32264efe79d0b86abd41236f1d5b.tar.gz
postgresql-bc43b7c2c06c32264efe79d0b86abd41236f1d5b.zip
Fix numeric_power() when the exponent is INT_MIN.
In power_var_int(), the computation of the number of significant digits to use in the computation used log(Abs(exp)), which isn't safe because Abs(exp) returns INT_MIN when exp is INT_MIN. Use fabs() instead of Abs(), so that the exponent is cast to a double before the absolute value is taken. Back-patch to 9.6, where this was introduced (by 7d9a4737c2). Discussion: https://postgr.es/m/CAEZATCVd6pMkz=BrZEgBKyqqJrt2xghr=fNc8+Z=5xC6cgWrWA@mail.gmail.com
Diffstat (limited to 'src/backend/utils/adt/numeric.c')
-rw-r--r--src/backend/utils/adt/numeric.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/adt/numeric.c b/src/backend/utils/adt/numeric.c
index 68d879160a5..7cf56568f38 100644
--- a/src/backend/utils/adt/numeric.c
+++ b/src/backend/utils/adt/numeric.c
@@ -10290,7 +10290,7 @@ power_var_int(const NumericVar *base, int exp, NumericVar *result, int rscale)
* to around log10(abs(exp)) digits, so work with this many extra digits
* of precision (plus a few more for good measure).
*/
- sig_digits += (int) log(Abs(exp)) + 8;
+ sig_digits += (int) log(fabs(exp)) + 8;
/*
* Now we can proceed with the multiplications.