aboutsummaryrefslogtreecommitdiff
path: root/src/backend/utils/adt/numeric.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2014-11-27 11:12:47 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2014-11-27 11:12:47 -0500
commite2d0c25917bef8c25bf6e9b1bcf2a75dbf8f07f0 (patch)
treeca70758b64f232ca7d57d3c2b30064e4688d386c /src/backend/utils/adt/numeric.c
parent6c1d521af35e496639bbb39764c30115879af47f (diff)
downloadpostgresql-e2d0c25917bef8c25bf6e9b1bcf2a75dbf8f07f0.tar.gz
postgresql-e2d0c25917bef8c25bf6e9b1bcf2a75dbf8f07f0.zip
Free libxml2/libxslt resources in a safer order.
Mark Simonetti reported that libxslt sometimes crashes for him, and that swapping xslt_process's object-freeing calls around to do them in reverse order of creation seemed to fix it. I've not reproduced the crash, but valgrind clearly shows a reference to already-freed memory, which is consistent with the idea that shutdown of the xsltTransformContext is trying to reference the already-freed stylesheet or input document. With this patch, valgrind is no longer unhappy. I have an inquiry in to see if this is a libxslt bug or if we're just abusing the library; but even if it's a library bug, we'd want to adjust our code so it doesn't fail with unpatched libraries. Back-patch to all supported branches, because we've been doing this in the wrong(?) order for a long time.
Diffstat (limited to 'src/backend/utils/adt/numeric.c')
0 files changed, 0 insertions, 0 deletions