diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2021-06-18 18:00:09 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2021-06-18 18:00:09 -0400 |
| commit | 33af10c598e2bff55be46eb79f7c785440aa13c5 (patch) | |
| tree | 81ee253749c3d05ff5b06faa1cfc7a6288161134 /src/backend/utils/adt/pg_locale.c | |
| parent | 102f31a208b85aec542fc93f73a222d98d551694 (diff) | |
| download | postgresql-33af10c598e2bff55be46eb79f7c785440aa13c5.tar.gz postgresql-33af10c598e2bff55be46eb79f7c785440aa13c5.zip | |
Fix misbehavior of DROP OWNED BY with duplicate polroles entries.
Ordinarily, a pg_policy.polroles array wouldn't list the same role
more than once; but CREATE POLICY does not prevent that. If we
perform DROP OWNED BY on a role that is listed more than once,
RemoveRoleFromObjectPolicy either suffered an assertion failure
or encountered a tuple-updated-by-self error. Rewrite it to cope
correctly with duplicate entries, and add a CommandCounterIncrement
call to prevent the other problem.
Per discussion, there's other cleanup that ought to happen here,
but this seems like the minimum essential fix.
Per bug #17062 from Alexander Lakhin. It's been broken all along,
so back-patch to all supported branches.
Discussion: https://postgr.es/m/17062-11f471ae3199ca23@postgresql.org
Diffstat (limited to 'src/backend/utils/adt/pg_locale.c')
0 files changed, 0 insertions, 0 deletions