diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2016-01-05 13:02:43 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2016-01-05 13:02:43 -0500 |
| commit | ea0d494dae0d3d6fce26bf5d6fbaa07e2ee6c402 (patch) | |
| tree | 48a2fcde511e2a8ec9870b614fd8e7f04f2bad6c /src/backend/utils/adt/regproc.c | |
| parent | efa318bcfac132c48dff8196f726e56a6843f06b (diff) | |
| download | postgresql-ea0d494dae0d3d6fce26bf5d6fbaa07e2ee6c402.tar.gz postgresql-ea0d494dae0d3d6fce26bf5d6fbaa07e2ee6c402.zip | |
Make the to_reg*() functions accept text not cstring.
Using cstring as the input type was a poor decision, because that's not
really a full-fledged type. In particular, it lacks implicit coercions
from text or varchar, meaning that usages like to_regproc('foo'||'bar')
wouldn't work; basically the only case that did work without explicit
casting was a simple literal constant argument.
The lack of field complaints about this suggests that hardly anyone
is using these functions, so hopefully fixing it won't cause much of
a compatibility problem. They've only been there since 9.4, anyway.
Petr Korobeinikov
Diffstat (limited to 'src/backend/utils/adt/regproc.c')
| -rw-r--r-- | src/backend/utils/adt/regproc.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/backend/utils/adt/regproc.c b/src/backend/utils/adt/regproc.c index 0f17eb8000f..394042cbbac 100644 --- a/src/backend/utils/adt/regproc.c +++ b/src/backend/utils/adt/regproc.c @@ -161,7 +161,7 @@ regprocin(PG_FUNCTION_ARGS) Datum to_regproc(PG_FUNCTION_ARGS) { - char *pro_name = PG_GETARG_CSTRING(0); + char *pro_name = text_to_cstring(PG_GETARG_TEXT_PP(0)); List *names; FuncCandidateList clist; @@ -331,7 +331,7 @@ regprocedurein(PG_FUNCTION_ARGS) Datum to_regprocedure(PG_FUNCTION_ARGS) { - char *pro_name = PG_GETARG_CSTRING(0); + char *pro_name = text_to_cstring(PG_GETARG_TEXT_PP(0)); List *names; int nargs; Oid argtypes[FUNC_MAX_ARGS]; @@ -620,7 +620,7 @@ regoperin(PG_FUNCTION_ARGS) Datum to_regoper(PG_FUNCTION_ARGS) { - char *opr_name = PG_GETARG_CSTRING(0); + char *opr_name = text_to_cstring(PG_GETARG_TEXT_PP(0)); List *names; FuncCandidateList clist; @@ -797,7 +797,7 @@ regoperatorin(PG_FUNCTION_ARGS) Datum to_regoperator(PG_FUNCTION_ARGS) { - char *opr_name_or_oid = PG_GETARG_CSTRING(0); + char *opr_name_or_oid = text_to_cstring(PG_GETARG_TEXT_PP(0)); Oid result; List *names; int nargs; @@ -1061,7 +1061,7 @@ regclassin(PG_FUNCTION_ARGS) Datum to_regclass(PG_FUNCTION_ARGS) { - char *class_name = PG_GETARG_CSTRING(0); + char *class_name = text_to_cstring(PG_GETARG_TEXT_PP(0)); Oid result; List *names; @@ -1249,7 +1249,7 @@ regtypein(PG_FUNCTION_ARGS) Datum to_regtype(PG_FUNCTION_ARGS) { - char *typ_name = PG_GETARG_CSTRING(0); + char *typ_name = text_to_cstring(PG_GETARG_TEXT_PP(0)); Oid result; int32 typmod; @@ -1606,7 +1606,7 @@ regrolein(PG_FUNCTION_ARGS) Datum to_regrole(PG_FUNCTION_ARGS) { - char *role_name = PG_GETARG_CSTRING(0); + char *role_name = text_to_cstring(PG_GETARG_TEXT_PP(0)); Oid result; List *names; @@ -1727,7 +1727,7 @@ regnamespacein(PG_FUNCTION_ARGS) Datum to_regnamespace(PG_FUNCTION_ARGS) { - char *nsp_name = PG_GETARG_CSTRING(0); + char *nsp_name = text_to_cstring(PG_GETARG_TEXT_PP(0)); Oid result; List *names; |