aboutsummaryrefslogtreecommitdiff
path: root/src/backend/utils/adt/ruleutils.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2016-04-04 11:13:17 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2016-04-04 11:13:39 -0400
commit5496c75de7140e0fedf2fba70bd2df08743d6a64 (patch)
tree9dbeaec5a4b4ee291ec93e11a618d7e77843d047 /src/backend/utils/adt/ruleutils.c
parente19b7f7c8bfb41899bdfa386049a0e2490ea6a79 (diff)
downloadpostgresql-5496c75de7140e0fedf2fba70bd2df08743d6a64.tar.gz
postgresql-5496c75de7140e0fedf2fba70bd2df08743d6a64.zip
Fix latent portability issue in pgwin32_dispatch_queued_signals().
The first iteration of the signal-checking loop would compute sigmask(0) which expands to 1<<(-1) which is undefined behavior according to the C standard. The lack of field reports of trouble suggest that it evaluates to 0 on all existing Windows compilers, but that's hardly something to rely on. Since signal 0 isn't a queueable signal anyway, we can just make the loop iterate from 1 instead, and save a few cycles as well as avoiding the undefined behavior. In passing, avoid evaluating the volatile expression UNBLOCKED_SIGNAL_QUEUE twice in a row; there's no reason to waste cycles like that. Noted by Aleksander Alekseev, though this isn't his proposed fix. Back-patch to all supported branches.
Diffstat (limited to 'src/backend/utils/adt/ruleutils.c')
0 files changed, 0 insertions, 0 deletions