diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2022-04-20 11:44:08 +0200 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2022-04-20 11:44:08 +0200 |
| commit | e70813fbc4aaca35ec012d5a426706bd54e4acab (patch) | |
| tree | 2f69ca39209038a8048c2b4af7db14687c9f71ed /src/backend/utils/adt/ruleutils.c | |
| parent | a87e75956926f966d90bdd1a6bd495cf59cdc3ad (diff) | |
| download | postgresql-e70813fbc4aaca35ec012d5a426706bd54e4acab.tar.gz postgresql-e70813fbc4aaca35ec012d5a426706bd54e4acab.zip | |
set_deparse_plan: Reuse variable to appease Coverity
Coverity complains that dpns->outer_plan is deferenced (to obtain
->targetlist) when possibly NULL. We can avoid this by using
dpns->outer_tlist instead, which was already obtained a few lines up.
The fact that we end up with
dpns->inner_tlist = dpns->outer_tlist
is a bit suspicious-looking and maybe worthy of more investigation, but
I'll leave that for another day.
Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/202204191345.qerjy3kxi3eb@alvherre.pgsql
Diffstat (limited to 'src/backend/utils/adt/ruleutils.c')
| -rw-r--r-- | src/backend/utils/adt/ruleutils.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c index 7e08d7fe6c2..5d49f564a2e 100644 --- a/src/backend/utils/adt/ruleutils.c +++ b/src/backend/utils/adt/ruleutils.c @@ -4996,7 +4996,7 @@ set_deparse_plan(deparse_namespace *dpns, Plan *plan) if (IsA(plan, ModifyTable)) { if (((ModifyTable *) plan)->operation == CMD_MERGE) - dpns->inner_tlist = dpns->outer_plan->targetlist; + dpns->inner_tlist = dpns->outer_tlist; else dpns->inner_tlist = ((ModifyTable *) plan)->exclRelTlist; } |