diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2011-10-23 00:43:39 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2011-10-23 00:43:39 -0400 |
| commit | 0f39d5050dc0dce99258381f33f1832c437aff85 (patch) | |
| tree | 90583250bd5cf7878686bad038ec74e9dd292744 /src/backend/utils/adt/selfuncs.c | |
| parent | bb446b689b6681eb57a8a50605e119743190c4db (diff) | |
| download | postgresql-0f39d5050dc0dce99258381f33f1832c437aff85.tar.gz postgresql-0f39d5050dc0dce99258381f33f1832c437aff85.zip | |
Don't trust deferred-unique indexes for join removal.
The uniqueness condition might fail to hold intra-transaction, and assuming
it does can give incorrect query results. Per report from Marti Raudsepp,
though this is not his proposed patch.
Back-patch to 9.0, where both these features were introduced. In the
released branches, add the new IndexOptInfo field to the end of the struct,
to try to minimize ABI breakage for third-party code that may be examining
that struct.
Diffstat (limited to 'src/backend/utils/adt/selfuncs.c')
| -rw-r--r-- | src/backend/utils/adt/selfuncs.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/backend/utils/adt/selfuncs.c b/src/backend/utils/adt/selfuncs.c index 96946281dab..f05cc4f87ee 100644 --- a/src/backend/utils/adt/selfuncs.c +++ b/src/backend/utils/adt/selfuncs.c @@ -4129,7 +4129,9 @@ get_join_variables(PlannerInfo *root, List *args, SpecialJoinInfo *sjinfo, * commonly the same as the exposed type of the variable argument, * but can be different in binary-compatible-type cases. * isunique: TRUE if we were able to match the var to a unique index, - * implying its values are unique for this query. + * implying its values are unique for this query. (Caution: this + * should be trusted for statistical purposes only, since we do not + * check indimmediate.) * * Caller is responsible for doing ReleaseVariableStats() before exiting. */ |