diff options
| author | Noah Misch <noah@leadboat.com> | 2024-11-02 09:05:00 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2024-11-02 09:05:02 -0700 |
| commit | 6f9dd2282e37589bdadf15423b0395ce11735f82 (patch) | |
| tree | f6237ed05d6cb2c3490dc6e7e634103caf01d617 /src/backend/utils/cache/syscache.c | |
| parent | d5be10758b3645e30937509d7056d2dc28eb128e (diff) | |
| download | postgresql-6f9dd2282e37589bdadf15423b0395ce11735f82.tar.gz postgresql-6f9dd2282e37589bdadf15423b0395ce11735f82.zip | |
Revert "For inplace update, send nontransactional invalidations."
This reverts commit 95c5acb3fc261067ab65ddc0b2dca8e162f09442 (v17) and
counterparts in each other non-master branch. If released, that commit
would have caused a worst-in-years minor release regression, via
undetected LWLock self-deadlock. This commit and its self-deadlock fix
warrant more bake time in the master branch.
Reported by Alexander Lakhin.
Discussion: https://postgr.es/m/10ec0bc3-5933-1189-6bb8-5dec4114558e@gmail.com
Diffstat (limited to 'src/backend/utils/cache/syscache.c')
| -rw-r--r-- | src/backend/utils/cache/syscache.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/backend/utils/cache/syscache.c b/src/backend/utils/cache/syscache.c index b0cc6a00eea..697b17bdd74 100644 --- a/src/backend/utils/cache/syscache.c +++ b/src/backend/utils/cache/syscache.c @@ -951,7 +951,8 @@ SearchSysCacheLocked1(int cacheId, /* * If an inplace update just finished, ensure we process the syscache - * inval. + * inval. XXX this is insufficient: the inplace updater may not yet + * have reached AtEOXact_Inval(). See test at inplace-inval.spec. * * If a heap_update() call just released its LOCKTAG_TUPLE, we'll * probably find the old tuple and reach "tuple concurrently updated". |