diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2001-01-12 21:54:01 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2001-01-12 21:54:01 +0000 |
| commit | 6162432de9fb023b710c171f196e27b910e45fa7 (patch) | |
| tree | 51bba2e60ca2d3497b365b23edd52d52574faae2 /src/backend/utils/cache/temprel.c | |
| parent | be8477bc3718a05b02dd7e9f8236c16394f9a027 (diff) | |
| download | postgresql-6162432de9fb023b710c171f196e27b910e45fa7.tar.gz postgresql-6162432de9fb023b710c171f196e27b910e45fa7.zip | |
Add more critical-section calls: all code sections that hold spinlocks
are now critical sections, so as to ensure die() won't interrupt us while
we are munging shared-memory data structures. Avoid insecure intermediate
states in some code that proc_exit will call, like palloc/pfree. Rename
START/END_CRIT_CODE to START/END_CRIT_SECTION, since that seems to be
what people tend to call them anyway, and make them be called with () like
a function call, in hopes of not confusing pg_indent.
I doubt that this is sufficient to make SIGTERM safe anywhere; there's
just too much code that could get invoked during proc_exit().
Diffstat (limited to 'src/backend/utils/cache/temprel.c')
| -rw-r--r-- | src/backend/utils/cache/temprel.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/backend/utils/cache/temprel.c b/src/backend/utils/cache/temprel.c index a0066f2eaff..b1580d65b49 100644 --- a/src/backend/utils/cache/temprel.c +++ b/src/backend/utils/cache/temprel.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/utils/cache/Attic/temprel.c,v 1.32 2000/12/22 23:12:07 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/utils/cache/Attic/temprel.c,v 1.33 2001/01/12 21:54:00 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -263,8 +263,6 @@ AtEOXact_temp_relations(bool isCommit) temp_rel->created_in_cur_xact) { /* This entry must be removed */ - pfree(temp_rel); - /* remove from linked list */ if (prev != NIL) { lnext(prev) = lnext(l); @@ -277,6 +275,7 @@ AtEOXact_temp_relations(bool isCommit) pfree(l); l = temp_rels; } + pfree(temp_rel); } else { |