diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2010-08-19 22:55:01 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2010-08-19 22:55:01 +0000 |
| commit | 79dc97a401e8b51c3b91f3d629122b3f6c365a9f (patch) | |
| tree | f8799d75c0ef71a9c458c7209e196113daf99e7a /src/backend/utils/misc/guc.c | |
| parent | 9676b01028139ca399f2564f6c4cb40fffe2ec07 (diff) | |
| download | postgresql-79dc97a401e8b51c3b91f3d629122b3f6c365a9f.tar.gz postgresql-79dc97a401e8b51c3b91f3d629122b3f6c365a9f.zip | |
Bring some sanity to the trace_recovery_messages code and docs.
Per gripe from Fujii Masao, though this is not exactly his proposed patch.
Categorize as DEVELOPER_OPTIONS and set context PGC_SIGHUP, as per Fujii,
but set the default to LOG because higher values aren't really sensible
(see the code for trace_recovery()). Fix the documentation to agree with
the code and to try to explain what the variable actually does. Get rid
of no-op calls trace_recovery(LOG), which accomplish nothing except to
demonstrate that this option confuses even its author.
Diffstat (limited to 'src/backend/utils/misc/guc.c')
| -rw-r--r-- | src/backend/utils/misc/guc.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index dac704ee4cd..3be7874f08a 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -10,7 +10,7 @@ * Written by Peter Eisentraut <peter_e@gmx.net>. * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.567 2010/08/13 20:10:53 rhaas Exp $ + * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.568 2010/08/19 22:55:01 tgl Exp $ * *-------------------------------------------------------------------- */ @@ -2829,13 +2829,17 @@ static struct config_enum ConfigureNamesEnum[] = }, { - {"trace_recovery_messages", PGC_SUSET, LOGGING_WHEN, - gettext_noop("Sets the message levels that are logged during recovery."), + {"trace_recovery_messages", PGC_SIGHUP, DEVELOPER_OPTIONS, + gettext_noop("Enables logging of recovery-related debugging information."), gettext_noop("Each level includes all the levels that follow it. The later" " the level, the fewer messages are sent.") }, &trace_recovery_messages, - DEBUG1, server_message_level_options, NULL, NULL + /* + * client_message_level_options allows too many values, really, + * but it's not worth having a separate options array for this. + */ + LOG, client_message_level_options, NULL, NULL }, { |