diff options
| author | Nathan Bossart <nathan@postgresql.org> | 2024-03-20 13:31:58 -0500 |
|---|---|---|
| committer | Nathan Bossart <nathan@postgresql.org> | 2024-03-20 13:31:58 -0500 |
| commit | 80686761c49d5194d224b344e968c26981611726 (patch) | |
| tree | 7ff7640bcf58bae4213cfe38e746035c7c89b82f /src/backend/utils/misc/guc_tables.c | |
| parent | 9acae56ce0b0812f3e940cf1f87e73e8d5784e78 (diff) | |
| download | postgresql-80686761c49d5194d224b344e968c26981611726.tar.gz postgresql-80686761c49d5194d224b344e968c26981611726.zip | |
Avoid overflow in MaybeRemoveOldWalSummaries().
This commit limits the maximum value of wal_summary_keep_time to
INT_MAX / SECS_PER_MINUTE to avoid overflow when it is converted to
seconds. In passing, use the HOURS_PER_DAY, MINS_PER_HOUR, and
SECS_PER_MINUTE macros in the code for this GUC instead of hard-
coding those values.
Discussion: https://postgr.es/m/20240314210010.GA3056455%40nathanxps13
Diffstat (limited to 'src/backend/utils/misc/guc_tables.c')
| -rw-r--r-- | src/backend/utils/misc/guc_tables.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c index 57d9de4dd92..1e71e7db4a0 100644 --- a/src/backend/utils/misc/guc_tables.c +++ b/src/backend/utils/misc/guc_tables.c @@ -3293,9 +3293,9 @@ struct config_int ConfigureNamesInt[] = GUC_UNIT_MIN, }, &wal_summary_keep_time, - 10 * 24 * 60, /* 10 days */ + 10 * HOURS_PER_DAY * MINS_PER_HOUR, /* 10 days */ 0, - INT_MAX, + INT_MAX / SECS_PER_MINUTE, NULL, NULL, NULL }, |