aboutsummaryrefslogtreecommitdiff
path: root/src/backend/utils
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2006-05-31 20:58:09 +0000
committerTom Lane <tgl@sss.pgh.pa.us>2006-05-31 20:58:09 +0000
commit8f165ee13b11baf17b91d858c535419c33a755d6 (patch)
tree24edff7fbb527e614b27305af7f5f44539f696f8 /src/backend/utils
parentc269f0f1e2c760dde7a2c95ab09f913fa2aef1c4 (diff)
downloadpostgresql-8f165ee13b11baf17b91d858c535419c33a755d6.tar.gz
postgresql-8f165ee13b11baf17b91d858c535419c33a755d6.zip
Make PG_MODULE_MAGIC required in shared libraries that are loaded into
the server. Per discussion, there seems no point in a waiting period before making this required.
Diffstat (limited to 'src/backend/utils')
-rw-r--r--src/backend/utils/fmgr/dfmgr.c18
1 files changed, 9 insertions, 9 deletions
diff --git a/src/backend/utils/fmgr/dfmgr.c b/src/backend/utils/fmgr/dfmgr.c
index a54ca550dd7..0aacf2be995 100644
--- a/src/backend/utils/fmgr/dfmgr.c
+++ b/src/backend/utils/fmgr/dfmgr.c
@@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
- * $PostgreSQL: pgsql/src/backend/utils/fmgr/dfmgr.c,v 1.84 2006/05/30 21:21:30 tgl Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/fmgr/dfmgr.c,v 1.85 2006/05/31 20:58:09 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@@ -188,14 +188,14 @@ load_external_function(char *filename, char *funcname,
}
else
{
- /*
- * Currently we do not reject modules for not having a
- * magic block, it would break every external module in
- * existence. At some point though, this will become an ERROR.
- */
- ereport(LOG,
- (errmsg("library \"%s\" does not have a magic block",
- fullname)));
+ /* try to unlink library */
+ pg_dlclose(file_scanner->handle);
+ free((char *) file_scanner);
+ /* complain */
+ ereport(ERROR,
+ (errmsg("incompatible library \"%s\": missing magic block",
+ fullname),
+ errhint("Extension libraries are now required to use the PG_MODULE_MAGIC macro.")));
}
/* OK to link it into list */