diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2017-02-25 16:12:24 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2017-02-25 16:12:55 -0500 |
| commit | 9e3755ecb2d058f7d123dd35a2e1784006190962 (patch) | |
| tree | f938cae7833ef756947d4ac074a83d31f5f6113d /src/backend/utils | |
| parent | 5639ceddcb7f3efa8751b2ba6e50cc1d27cc2a45 (diff) | |
| download | postgresql-9e3755ecb2d058f7d123dd35a2e1784006190962.tar.gz postgresql-9e3755ecb2d058f7d123dd35a2e1784006190962.zip | |
Remove useless duplicate inclusions of system header files.
c.h #includes a number of core libc header files, such as <stdio.h>.
There's no point in re-including these after having read postgres.h,
postgres_fe.h, or c.h; so remove code that did so.
While at it, also fix some places that were ignoring our standard pattern
of "include postgres[_fe].h, then system header files, then other Postgres
header files". While there's not any great magic in doing it that way
rather than system headers last, it's silly to have just a few files
deviating from the general pattern. (But I didn't attempt to enforce this
globally, only in files I was touching anyway.)
I'd be the first to say that this is mostly compulsive neatnik-ism,
but over time it might save enough compile cycles to be useful.
Diffstat (limited to 'src/backend/utils')
| -rw-r--r-- | src/backend/utils/adt/cash.c | 1 | ||||
| -rw-r--r-- | src/backend/utils/adt/dbsize.c | 1 | ||||
| -rw-r--r-- | src/backend/utils/adt/inet_cidr_ntop.c | 1 | ||||
| -rw-r--r-- | src/backend/utils/adt/inet_net_pton.c | 1 | ||||
| -rw-r--r-- | src/backend/utils/adt/pg_locale.c | 1 | ||||
| -rw-r--r-- | src/backend/utils/init/miscinit.c | 1 |
6 files changed, 0 insertions, 6 deletions
diff --git a/src/backend/utils/adt/cash.c b/src/backend/utils/adt/cash.c index ac8f74fee63..5afadb65d11 100644 --- a/src/backend/utils/adt/cash.c +++ b/src/backend/utils/adt/cash.c @@ -21,7 +21,6 @@ #include <limits.h> #include <ctype.h> #include <math.h> -#include <locale.h> #include "libpq/pqformat.h" #include "utils/builtins.h" diff --git a/src/backend/utils/adt/dbsize.c b/src/backend/utils/adt/dbsize.c index ec3a28cd0d0..8cdd1dc4f79 100644 --- a/src/backend/utils/adt/dbsize.c +++ b/src/backend/utils/adt/dbsize.c @@ -11,7 +11,6 @@ #include "postgres.h" -#include <sys/types.h> #include <sys/stat.h> #include "access/heapam.h" diff --git a/src/backend/utils/adt/inet_cidr_ntop.c b/src/backend/utils/adt/inet_cidr_ntop.c index d33534ec173..d5d1289d7d9 100644 --- a/src/backend/utils/adt/inet_cidr_ntop.c +++ b/src/backend/utils/adt/inet_cidr_ntop.c @@ -23,7 +23,6 @@ static const char rcsid[] = "Id: inet_net_ntop.c,v 1.1.2.2 2004/03/09 09:17:27 m #include "postgres.h" -#include <sys/types.h> #include <sys/socket.h> #include <netinet/in.h> #include <arpa/inet.h> diff --git a/src/backend/utils/adt/inet_net_pton.c b/src/backend/utils/adt/inet_net_pton.c index b8fa7d2bccf..be788d37cd0 100644 --- a/src/backend/utils/adt/inet_net_pton.c +++ b/src/backend/utils/adt/inet_net_pton.c @@ -23,7 +23,6 @@ static const char rcsid[] = "Id: inet_net_pton.c,v 1.4.2.3 2004/03/17 00:40:11 m #include "postgres.h" -#include <sys/types.h> #include <sys/socket.h> #include <netinet/in.h> #include <arpa/inet.h> diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_locale.c index 4c7f1dad50e..ab197025f81 100644 --- a/src/backend/utils/adt/pg_locale.c +++ b/src/backend/utils/adt/pg_locale.c @@ -51,7 +51,6 @@ #include "postgres.h" -#include <locale.h> #include <time.h> #include "access/htup_details.h" diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c index e984e79c602..e0298ee35ff 100644 --- a/src/backend/utils/init/miscinit.c +++ b/src/backend/utils/init/miscinit.c @@ -20,7 +20,6 @@ #include <sys/file.h> #include <sys/stat.h> #include <sys/time.h> -#include <sys/types.h> #include <fcntl.h> #include <unistd.h> #include <grp.h> |