diff options
| author | Michael Paquier <michael@paquier.xyz> | 2024-02-01 17:13:11 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2024-02-01 17:13:11 +0900 |
| commit | 171d21f50c3ee3f17911daa3d91eb75363669a11 (patch) | |
| tree | 84db63e891a473c7c9ad646d629611a61bb7ea35 /src/backend | |
| parent | 41fa4b31c12f4affc5d0ed1e257dacaf2bbe0731 (diff) | |
| download | postgresql-171d21f50c3ee3f17911daa3d91eb75363669a11.tar.gz postgresql-171d21f50c3ee3f17911daa3d91eb75363669a11.zip | |
Fix stats_fetch_consistency with stats for fixed-numbered objects
This impacts the statistics retrieved in transactions for the following
views when updating the value of stats_fetch_consistency, leading to
behaviors contrary to what is documented since 605994651b6a as an update
of this parameter should discard all statistics snapshot data:
- pg_stat_archiver
- pg_stat_bgwriter
- pg_stat_checkpointer
- pg_stat_io
- pg_stat_slru
- pg_stat_wal
For example, updating stats_fetch_consistency from "snapshot" to "cache"
in a transaction did not re-fetch any fresh data, using data cached from
the time when "snapshot" was in use.
Author: Shinya Kato
Discussion: https://postgr.es/m/d77fc5190d4dbe1738d77231488e768b@oss.nttdata.com
Backpatch-through: 15
Diffstat (limited to 'src/backend')
| -rw-r--r-- | src/backend/utils/activity/pgstat.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/backend/utils/activity/pgstat.c b/src/backend/utils/activity/pgstat.c index 84d65a76af1..142e26af52e 100644 --- a/src/backend/utils/activity/pgstat.c +++ b/src/backend/utils/activity/pgstat.c @@ -918,6 +918,9 @@ pgstat_snapshot_fixed(PgStat_Kind kind) AssertArg(pgstat_is_kind_valid(kind)); AssertArg(pgstat_get_kind_info(kind)->fixed_amount); + if (force_stats_snapshot_clear) + pgstat_clear_snapshot(); + if (pgstat_fetch_consistency == PGSTAT_FETCH_CONSISTENCY_SNAPSHOT) pgstat_build_snapshot(); else |