diff options
| author | Michael Paquier <michael@paquier.xyz> | 2023-02-13 09:07:33 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2023-02-13 09:07:33 +0900 |
| commit | 2a507f6fd8b75c5197a58aac7c8003befd072003 (patch) | |
| tree | 1cc17fdf11bf3f623ad5ec0ac6685dd4b6745885 /src/backend | |
| parent | 6ded4a5a3de1e8d5f3ec50efd4a2d7a39d2550a6 (diff) | |
| download | postgresql-2a507f6fd8b75c5197a58aac7c8003befd072003.tar.gz postgresql-2a507f6fd8b75c5197a58aac7c8003befd072003.zip | |
Mark more nodes with attribute no_query_jumble
This commit removes most of the Plan and Path nodes, which should never
be included in the query jumbling because we ignore these in Query
nodes. This is facilitated by making no_query_jumble an inherited
attribute, like no_copy, no_equal and no_read when the supertype of a
node is found as marked with that.
RawStmt is not used in parsed queries, so it can be removed from the
query jumbling. A couple of nodes defined in pathnodes.h, plannodes.h
and primnodes.h with NodeTag as supertype need to be marked
individually.
Forcing the execution of the query jumbling code with compute_query_id =
auto while pg_stat_statements is loaded brings the code coverage of
queryjumblefuncs.funcs.c to 95.6%.
The core code does not yet include a way to enforce the execution in
query jumbling except in pg_stat_statements, so the numbers I am
mentioning above will not reflect on the default coverage report with
just what is done in this commit.
Reported-by: Tom Lane
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/3344827.1675809127@sss.pgh.pa.us
Diffstat (limited to 'src/backend')
| -rw-r--r-- | src/backend/nodes/gen_node_support.pl | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/backend/nodes/gen_node_support.pl b/src/backend/nodes/gen_node_support.pl index 19ed29657c1..ecbcadb8bf5 100644 --- a/src/backend/nodes/gen_node_support.pl +++ b/src/backend/nodes/gen_node_support.pl @@ -121,7 +121,7 @@ my %node_type_info; my @no_copy; # node types we don't want equal support for my @no_equal; -# node types we don't want jumble support for +# node types we don't want query jumble support for my @no_query_jumble; # node types we don't want read support for my @no_read; @@ -422,6 +422,8 @@ foreach my $infile (@ARGV) if elem $supertype, @no_equal; push @no_read, $in_struct if elem $supertype, @no_read; + push @no_query_jumble, $in_struct + if elem $supertype, @no_query_jumble; } } |