diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2007-07-02 20:12:05 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2007-07-02 20:12:05 +0000 |
| commit | 5d798ba82fb92fac7c75947df3f5059bebd67a1f (patch) | |
| tree | ed197d11755560ffd7d3ebeb318ab1aa9d9d97f7 /src/backend | |
| parent | 2fc24025668f1fbf0df5bba9bdf08e9afc921263 (diff) | |
| download | postgresql-5d798ba82fb92fac7c75947df3f5059bebd67a1f.tar.gz postgresql-5d798ba82fb92fac7c75947df3f5059bebd67a1f.zip | |
Fix failure to restart Postgres when Linux kernel returns EIDRM for shmctl().
This is a Linux kernel bug that apparently exists in every extant kernel
version: sometimes shmctl() will fail with EIDRM when EINVAL is correct.
We were assuming that EIDRM indicates a possible conflict with pre-existing
backends, and refusing to start the postmaster when this happens. Fortunately,
there does not seem to be any case where Linux can legitimately return EIDRM
(it doesn't track shmem segments in a way that would allow that), so we can
get away with just assuming that EIDRM means EINVAL on this platform.
Per reports from Michael Fuhr and Jon Lapham --- it's a bit surprising
we have not seen more reports, actually.
Diffstat (limited to 'src/backend')
| -rw-r--r-- | src/backend/port/sysv_shmem.c | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/src/backend/port/sysv_shmem.c b/src/backend/port/sysv_shmem.c index 3092ca2a377..b64f64b466f 100644 --- a/src/backend/port/sysv_shmem.c +++ b/src/backend/port/sysv_shmem.c @@ -10,7 +10,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/port/sysv_shmem.c,v 1.44 2005/10/15 02:49:22 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/port/sysv_shmem.c,v 1.44.2.1 2007/07/02 20:12:05 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -225,6 +225,18 @@ PGSharedMemoryIsInUse(unsigned long id1, unsigned long id2) return false; /* + * Some Linux kernel versions (in fact, all of them as of July 2007) + * sometimes return EIDRM when EINVAL is correct. The Linux kernel + * actually does not have any internal state that would justify + * returning EIDRM, so we can get away with assuming that EIDRM is + * equivalent to EINVAL on that platform. + */ +#ifdef HAVE_LINUX_EIDRM_BUG + if (errno == EIDRM) + return false; +#endif + + /* * Otherwise, we had better assume that the segment is in use. The * only likely case is EIDRM, which implies that the segment has been * IPC_RMID'd but there are still processes attached to it. |