aboutsummaryrefslogtreecommitdiff
path: root/src/backend
diff options
context:
space:
mode:
authorTomas Vondra <tomas.vondra@postgresql.org>2022-01-23 03:36:55 +0100
committerTomas Vondra <tomas.vondra@postgresql.org>2022-01-23 03:59:50 +0100
commit93854d5b1bf340858a46a9696320dac1065b9c32 (patch)
treee53749760e84cf7ea13fa5028967d83360894b6c /src/backend
parente2d53c8767da9f98c7c4c8d0b129171848472c93 (diff)
downloadpostgresql-93854d5b1bf340858a46a9696320dac1065b9c32.tar.gz
postgresql-93854d5b1bf340858a46a9696320dac1065b9c32.zip
Correct type of front_pathkey to PathKey
In sort_inner_and_outer we iterate a list of PathKey elements, but the variable is declared as (List *). This mistake is benign, because we only pass the pointer to lcons() and never dereference it. This exists since ~2004, but it's confusing. So fix and backpatch to all supported branches. Backpatch-through: 10 Discussion: https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com
Diffstat (limited to 'src/backend')
-rw-r--r--src/backend/optimizer/path/joinpath.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/optimizer/path/joinpath.c b/src/backend/optimizer/path/joinpath.c
index dc28b56e742..c49c58289df 100644
--- a/src/backend/optimizer/path/joinpath.c
+++ b/src/backend/optimizer/path/joinpath.c
@@ -996,7 +996,7 @@ sort_inner_and_outer(PlannerInfo *root,
foreach(l, all_pathkeys)
{
- List *front_pathkey = (List *) lfirst(l);
+ PathKey *front_pathkey = (PathKey *) lfirst(l);
List *cur_mergeclauses;
List *outerkeys;
List *innerkeys;