diff options
| author | Noah Misch <noah@leadboat.com> | 2020-05-13 20:42:09 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2020-05-13 20:42:24 -0700 |
| commit | 73a5c0d81ea611ad59051fe52a4b9e72b9e90289 (patch) | |
| tree | cb959631a766bf8d61fd0b59e05bb95b35d4c4ab /src/bin/pg_basebackup/pg_recvlogical.c | |
| parent | 7130be8aa3e022b08245f77cbbe5a71473b36a73 (diff) | |
| download | postgresql-73a5c0d81ea611ad59051fe52a4b9e72b9e90289.tar.gz postgresql-73a5c0d81ea611ad59051fe52a4b9e72b9e90289.zip | |
Fix pg_recvlogical avoidance of superfluous Standby Status Update.
The defect suppressed a Standby Status Update message when bytes flushed
to disk had changed but bytes received had not changed. If
pg_recvlogical then exited with no intervening Standby Status Update,
the next pg_recvlogical repeated already-flushed records. The defect
could also cause superfluous messages, which are functionally harmless.
Back-patch to 9.5 (all supported versions).
Discussion: https://postgr.es/m/20200502221647.GA3941274@rfd.leadboat.com
Diffstat (limited to 'src/bin/pg_basebackup/pg_recvlogical.c')
| -rw-r--r-- | src/bin/pg_basebackup/pg_recvlogical.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bin/pg_basebackup/pg_recvlogical.c b/src/bin/pg_basebackup/pg_recvlogical.c index 679b901964b..e153390f5e3 100644 --- a/src/bin/pg_basebackup/pg_recvlogical.c +++ b/src/bin/pg_basebackup/pg_recvlogical.c @@ -128,7 +128,7 @@ sendFeedback(PGconn *conn, TimestampTz now, bool force, bool replyRequested) */ if (!force && last_written_lsn == output_written_lsn && - last_fsync_lsn != output_fsync_lsn) + last_fsync_lsn == output_fsync_lsn) return true; if (verbose) |